Attachment 71329 Details for Bug 20156 – Bug 20156 - Staff client header language menu doesn't show check mark for current language

[patch] Bug 20156 - Staff client header language menu doesn't show check mark for current language

Bug-20156---Staff-client-header-language-menu-does.patch (text/plain), 4.59 KB, created by Katrin Fischer on 2018-02-07 21:20:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-02-07 21:20:04 UTC

Size: 4.59 KB

patch

obsolete

>From 5b8c7c75bb019607e48885623241499687fe0691 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 7 Feb 2018 17:42:09 +0000
>Subject: [PATCH] Bug 20156 - Staff client header language menu doesn't show
> check mark for current language
>
>This patch replaces Glyphicon markup with Font Awesome markup so that a
>check mark appears next to the currently-selected language in the staff
>client header's language menu.
>
>Also changed in this patch: Some classes have been removed because they
>are not used in staff client CSS.
>
>To test you must have multiple languages installed and enabled in the
>staff client.
>
> - Set the StaffLangSelectorMode system preference to "top" or "both top
> and footer"
> - Confirm that the currently-select language in the langauge menu has a
> check mark next to it.
>
>Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/langmenu-staff-top.inc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/langmenu-staff-top.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/langmenu-staff-top.inc
>index 11a06ac..544e341 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/langmenu-staff-top.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/langmenu-staff-top.inc
>@@ -9,18 +9,18 @@
> [% FOREACH sublanguages_loo IN languages_loo.sublanguages_loop %]
> [% IF ( sublanguages_loo.enabled ) %]
> [% IF ( sublanguages_loo.sublanguage_current ) %]
>- <li role="presentation"> <a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]&nbsp;</a></li>
>+ <li role="presentation"> <a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]&nbsp;</a></li>
> [% ELSE %]
>- <li role="presentation"><a href="/cgi-bin/koha/changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem" class="listmenulink"> [% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]</a></li>
>+ <li role="presentation"><a href="/cgi-bin/koha/changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem"> [% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]</a></li>
> [% END %]
> [% END # / IF sublanguages_loo.enabled %]
> [% END # / FOREACH sublanguages_loo %]
> [% ELSE %]
> [% IF ( languages_loo.group_enabled ) %]
> [% IF ( languages_loo.current ) %]
>- <li role="presentation"><a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]&nbsp;</a></li>
>+ <li role="presentation"><a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]&nbsp;</a></li>
> [% ELSE %]
>- <li role="presentation"><a href="/cgi-bin/koha/changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem" class="listmenulink">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li>
>+ <li role="presentation"><a href="/cgi-bin/koha/changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li>
> [% END %]
> [% END # / IF languages_loo.current %]
> [% END # / IF ( languages_loo.plural ) %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20156: 71297 | 71298 | 71329