Attachment 71430 Details for Bug 20144 – Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests

[patch] Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests

Bug-20144-sqlmodes-Add-default-value-for-subscript.patch (text/plain), 1.52 KB, created by Julian Maurice on 2018-02-12 10:32:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2018-02-12 10:32:36 UTC

Size: 1.52 KB

patch

obsolete

>From 2b22d9cca8bc574f39dd7d18e4c5b68453fdb956 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 5 Feb 2018 17:48:03 -0300
>Subject: [PATCH] Bug 20144: [sql_modes] Add default value for
> subscription_numberpatterns.description in tests
>
>Fix for:
>Field 'description' doesn't have a default value
>
>t/db_dependent/AdditionalField.t
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> C4/Serials/Numberpattern.pm      | 1 +
> t/db_dependent/AdditionalField.t | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/C4/Serials/Numberpattern.pm b/C4/Serials/Numberpattern.pm
>index 210b8dd487..3c35b628dc 100644
>--- a/C4/Serials/Numberpattern.pm
>+++ b/C4/Serials/Numberpattern.pm
>@@ -139,6 +139,7 @@ sub AddSubscriptionNumberpattern {
>         return;
>     }
> 
>+    # FIXME label, description and numberingmethod must be mandatory
>     my @keys;
>     my @values;
>     foreach (qw/ label description numberingmethod displayorder
>diff --git a/t/db_dependent/AdditionalField.t b/t/db_dependent/AdditionalField.t
>index 59620b8a44..93121db687 100644
>--- a/t/db_dependent/AdditionalField.t
>+++ b/t/db_dependent/AdditionalField.t
>@@ -125,6 +125,7 @@ my $budget_id = AddBudget({
> my $frequency_id = AddSubscriptionFrequency({ description => "Test frequency 1" });
> my $pattern_id = AddSubscriptionNumberpattern({
>     label => 'Test numberpattern 1',
>+    description => 'Description for numberpattern 1',
>     numberingmethod => '{X}'
> });
> 
>-- 
>2.14.2

Actions: View | Diff | Splinter Review

Attachments on bug 20144: 71410 | 71411 | 71412 | 71413 | 71414 | 71415 | 71416 | 71417 | 71418 | 71419 | 71420 | 71421 | 71422 | 71423 | 71424 | 71425 | 71427 | 71428 | 71429 | 71430 | 71431 | 71432 | 71434 | 71435 | 71436 | 71437 | 71438 | 71440 | 71441 | 71442 | 71443 | 71444 | 71445 | 71446 | 71447 | 71448 | 71449 | 71450 | 71451 | 71452 | 71453 | 71454 | 71455 | 71456 | 71457 | 71458 | 71459 | 71460 | 71461 | 71462 | 71463 | 71467 | 71564