Attachment 71434 Details for Bug 20144 – Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT

[patch] Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT

Bug-20144-sqlmodes-Set-importrecordsmarcxmlold-to-.patch (text/plain), 1.71 KB, created by Julian Maurice on 2018-02-12 10:49:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2018-02-12 10:49:38 UTC

Size: 1.71 KB

patch

obsolete

>From 16b243c49b0c8f5c1491db094280742afb79903d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 5 Feb 2018 18:19:53 -0300
>Subject: [PATCH] Bug 20144: [sql_modes] Set import_records.marcxml_old to ''
> on INSERT
>
>Fix for:
>Field 'marcxml_old' doesn't have a default value
>
>t/db_dependent/ImportBatch.t
>
>Fixme - need to update existing DB?
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> C4/ImportBatch.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm
>index 1b74929c18..3727f4152d 100644
>--- a/C4/ImportBatch.pm
>+++ b/C4/ImportBatch.pm
>@@ -1595,10 +1595,10 @@ sub _create_import_record {
>     my ($batch_id, $record_sequence, $marc_record, $record_type, $encoding, $z3950random, $marc_type) = @_;
> 
>     my $dbh = C4::Context->dbh;
>-    my $sth = $dbh->prepare("INSERT INTO import_records (import_batch_id, record_sequence, marc, marcxml, 
>+    my $sth = $dbh->prepare("INSERT INTO import_records (import_batch_id, record_sequence, marc, marcxml, marcxml_old,
>                                                          record_type, encoding, z3950random)
>-                                    VALUES (?, ?, ?, ?, ?, ?, ?)");
>-    $sth->execute($batch_id, $record_sequence, $marc_record->as_usmarc(), $marc_record->as_xml($marc_type),
>+                                    VALUES (?, ?, ?, ?, ?, ?, ?, ?)");
>+    $sth->execute($batch_id, $record_sequence, $marc_record->as_usmarc(), $marc_record->as_xml($marc_type), '',
>                   $record_type, $encoding, $z3950random);
>     my $import_record_id = $dbh->{'mysql_insertid'};
>     $sth->finish();
>-- 
>2.14.2

Actions: View | Diff | Splinter Review

Attachments on bug 20144: 71410 | 71411 | 71412 | 71413 | 71414 | 71415 | 71416 | 71417 | 71418 | 71419 | 71420 | 71421 | 71422 | 71423 | 71424 | 71425 | 71427 | 71428 | 71429 | 71430 | 71431 | 71432 | 71434 | 71435 | 71436 | 71437 | 71438 | 71440 | 71441 | 71442 | 71443 | 71444 | 71445 | 71446 | 71447 | 71448 | 71449 | 71450 | 71451 | 71452 | 71453 | 71454 | 71455 | 71456 | 71457 | 71458 | 71459 | 71460 | 71461 | 71462 | 71463 | 71467 | 71564