Bugzilla – Attachment 71453 Details for
Bug 20144
Test suite is failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp
Bug-20144-sqlmodes-Set-value-for-pendingofflineope.patch (text/plain), 1.85 KB, created by
Julian Maurice
on 2018-02-12 12:32:45 UTC
(
hide
)
Description:
Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 12:32:45 UTC
Size:
1.85 KB
patch
obsolete
>From 5d9bc4b639852b2a7e49b1fd0facfd2183a0b838 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Feb 2018 12:51:19 -0300 >Subject: [PATCH] Bug 20144: [sql_modes] Set value for > pending_offline_operations.timestamp > >Not null > >Fix for: >Incorrect datetime value: 'null' for column 'timestamp' > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/Circulation/OfflineOperation.t | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation/OfflineOperation.t b/t/db_dependent/Circulation/OfflineOperation.t >index 387ae6427f..c50524dd51 100644 >--- a/t/db_dependent/Circulation/OfflineOperation.t >+++ b/t/db_dependent/Circulation/OfflineOperation.t >@@ -2,6 +2,8 @@ > > use Modern::Perl; > use C4::Circulation; >+ >+use Koha::DateUtils qw( dt_from_string output_pref ); > use Koha::Library; > > use Test::More tests => 7; >@@ -51,12 +53,14 @@ my $samplebranch1 = { > }; > Koha::Library->new($samplebranch1)->store; > >+my $now = dt_from_string->truncate( to => 'minute' ); >+ > #Begin Tests > #Test AddOfflineOperation > is( > AddOfflineOperation( > 'User1', $samplebranch1->{branchcode}, >- 'null', 'Action1', 'CODE', 'Cardnumber1', 10 >+ $now, 'Action1', 'CODE', 'Cardnumber1', 10 > ), > 'Added.', > "OfflineOperation has been added" >@@ -71,7 +75,8 @@ is_deeply( > operationid => $offline_id, > userid => 'User1', > branchcode => $samplebranch1->{branchcode}, >- timestamp => "0000-00-00 00:00:00", >+ # FIXME sounds like we need a 'timestamp' dateformat >+ timestamp => output_pref({ dt => $now, dateformat => 'iso', dateonly => 0 }) . ':00', > action => 'Action1', > barcode => 'CODE', > cardnumber => 'Cardnumber1', >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20144
:
71410
|
71411
|
71412
|
71413
|
71414
|
71415
|
71416
|
71417
|
71418
|
71419
|
71420
|
71421
|
71422
|
71423
|
71424
|
71425
|
71427
|
71428
|
71429
|
71430
|
71431
|
71432
|
71434
|
71435
|
71436
|
71437
|
71438
|
71440
|
71441
|
71442
|
71443
|
71444
|
71445
|
71446
|
71447
|
71448
|
71449
|
71450
|
71451
|
71452
| 71453 |
71454
|
71455
|
71456
|
71457
|
71458
|
71459
|
71460
|
71461
|
71462
|
71463
|
71467
|
71564