Attachment 71457 Details for Bug 20144 – Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in GetItemsForInventory

[patch] Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in GetItemsForInventory

Bug-20144-sqlmodes-Remove-ORDER-BY-clause-for-COUN.patch (text/plain), 1.94 KB, created by Julian Maurice on 2018-02-12 12:44:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2018-02-12 12:44:22 UTC

Size: 1.94 KB

patch

obsolete

>From 23f074ce2dc010af4c9d13d1a3eebf3a0b4c04d9 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 6 Feb 2018 13:39:51 -0300
>Subject: [PATCH] Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in
> GetItemsForInventory
>
>Fix for:
>DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement 'SELECT COUNT(*)
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> C4/Items.pm                                 | 2 +-
> t/db_dependent/Items/GetItemsForInventory.t | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index a7154be82a..c765cc996f 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -882,8 +882,8 @@ sub GetItemsForInventory {
>         $query .= 'WHERE ';
>         $query .= join ' AND ', @where_strings;
>     }
>-    $query .= ' ORDER BY items.cn_sort, itemcallnumber, title';
>     my $count_query = $select_count . $query;
>+    $query .= ' ORDER BY items.cn_sort, itemcallnumber, title';
>     $query .= " LIMIT $offset, $size" if ($offset and $size);
>     $query = $select_columns . $query;
>     my $sth = $dbh->prepare($query);
>diff --git a/t/db_dependent/Items/GetItemsForInventory.t b/t/db_dependent/Items/GetItemsForInventory.t
>index 452b15eb66..17ab8c1615 100755
>--- a/t/db_dependent/Items/GetItemsForInventory.t
>+++ b/t/db_dependent/Items/GetItemsForInventory.t
>@@ -123,8 +123,8 @@ sub OldWay {
>         $query .= 'WHERE ';
>         $query .= join ' AND ', @where_strings;
>     }
>-    $query .= ' ORDER BY items.cn_sort, itemcallnumber, title';
>     my $count_query = $select_count . $query;
>+    $query .= ' ORDER BY items.cn_sort, itemcallnumber, title';
>     $query .= " LIMIT $offset, $size" if ($offset and $size);
>     $query = $select_columns . $query;
>     my $sth = $ldbh->prepare($query);
>-- 
>2.14.2

Actions: View | Diff | Splinter Review

Attachments on bug 20144: 71410 | 71411 | 71412 | 71413 | 71414 | 71415 | 71416 | 71417 | 71418 | 71419 | 71420 | 71421 | 71422 | 71423 | 71424 | 71425 | 71427 | 71428 | 71429 | 71430 | 71431 | 71432 | 71434 | 71435 | 71436 | 71437 | 71438 | 71440 | 71441 | 71442 | 71443 | 71444 | 71445 | 71446 | 71447 | 71448 | 71449 | 71450 | 71451 | 71452 | 71453 | 71454 | 71455 | 71456 | 71457 | 71458 | 71459 | 71460 | 71461 | 71462 | 71463 | 71467 | 71564