Bugzilla – Attachment 71468 Details for
Bug 20177
Remove GROUP BY clause in GetCourses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20177: [sql_modes] Remove GROUP BY clause in GetCourses
Bug-20177-sqlmodes-Remove-GROUP-BY-clause-in-GetCo.patch (text/plain), 899 bytes, created by
Julian Maurice
on 2018-02-12 13:46:40 UTC
(
hide
)
Description:
Bug 20177: [sql_modes] Remove GROUP BY clause in GetCourses
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 13:46:40 UTC
Size:
899 bytes
patch
obsolete
>From eb231d8f186e7acfcc7f8c959e85651dbe6c14de Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 5 Feb 2018 18:13:06 -0300 >Subject: [PATCH] Bug 20177: [sql_modes] Remove GROUP BY clause in GetCourses > >Fix for: >'koha_kohadev.courses.department' isn't in GROUP BY > >t/db_dependent/CourseReserves.t > >no need to group by here > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > C4/CourseReserves.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm >index 3a3f422a96..91141a1543 100644 >--- a/C4/CourseReserves.pm >+++ b/C4/CourseReserves.pm >@@ -180,8 +180,6 @@ sub GetCourses { > $query .= join( ' AND ', @query_keys ); > } > >- $query .= " GROUP BY courses.course_id "; >- > my $dbh = C4::Context->dbh; > my $sth = $dbh->prepare($query); > $sth->execute(@query_values); >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20177
:
71468
|
71620
|
79405
|
80080