Bugzilla – Attachment 71499 Details for
Bug 20054
Remove attribute "text/css" for the style tags used in the OPAC templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20054: Remove attribute "text/css" for <style> element in OPAC
Bug-20054-Remove-attribute-textcss-for-style-eleme.patch (text/plain), 11.75 KB, created by
Jonathan Druart
on 2018-02-12 19:15:57 UTC
(
hide
)
Description:
Bug 20054: Remove attribute "text/css" for <style> element in OPAC
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-02-12 19:15:57 UTC
Size:
11.75 KB
patch
obsolete
>From 7c8afb8dfe5573f264efc8903dc38a34fc1ee414 Mon Sep 17 00:00:00 2001 >From: "Indranil Das Gupta (L2C2 Technologies)" <indradg@l2c2.co.in> >Date: Sun, 21 Jan 2018 23:59:35 +0530 >Subject: [PATCH] Bug 20054: Remove attribute "text/css" for <style> element in > OPAC > >Conformance rules for HTML5 is generating warnings for <style> element >with type="text/css" attribute when the OPAC page is checked >with W3C Validator. > >Test plan >========= > >1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC > page (if it is hosted) to W3C Validator and watch the warning about > type attribute "text/css". > >2/ Apply patch and re-submit the page to the Validator. The warning > will be gone. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: maksim <maksim@inlibro.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 4 ++-- > 12 files changed, 15 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc >index 838606e0a9..e99db29a1a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc >@@ -34,11 +34,11 @@ > [% IF ( bidi ) %] > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/right-to-left_[% KOHA_VERSION %].css" /> > [% END %] >-[% IF ( OPACUserCSS ) %]<style type="text/css">[% OPACUserCSS %]</style>[% END %] >+[% IF ( OPACUserCSS ) %]<style>[% OPACUserCSS %]</style>[% END %] > [% IF SCO_login %] > [% SET SCOUserCSS = Koha.Preference('SCOUserCSS') %] > [% IF SCOUserCSS %] >- <style type="text/css">[% SCOUserCSS %]</style> >+ <style>[% SCOUserCSS %]</style> > [% END %] > [% END %] > <link rel="unapi-server" type="application/xml" title="unAPI" href="[% OPACBaseURL %]/cgi-bin/koha/unapi" /> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt >index c4413a72a5..b7e0f750bf 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt >@@ -3,7 +3,7 @@ > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css"> >+ <style> > #opac-maintenance-message { > background:none repeat scroll 0 0 #FFFFFF; > border:1px solid #A2A2A2; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >index 383dea8ead..2350369eb1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >@@ -5,7 +5,7 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Your cart</title> > [% INCLUDE 'doc-head-close.inc' %] >-[% BLOCK cssinclude %]<style type="text/css">.item-status { display: inline; }</style>[% END %] >+[% BLOCK cssinclude %]<style>.item-status { display: inline; }</style>[% END %] > </head> > [% INCLUDE 'bodytag.inc' bodyid='basket' %] > <div class="main"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt >index 5e81d2396a..1631fa2690 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt >@@ -5,7 +5,7 @@ > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Full subscription history for [% bibliotitle %]</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css"> >+ <style> > #search-facets fieldset { border: 0; margin: 0;padding:0;}#search-facets ol{padding:.3em;}#search-facets li {list-style-type:none;padding:4px 4px;}#search-facets label{font-weight:bold;display:block;margin:.2em 0;}#search-facets fieldset.action {padding-left:4px;margin:.3em;}div.tabsub { clear:both;}#subtabs a { display:block;float:left;border:1px solid #CCC;padding:.2em .4em;margin:.3em;text-decoration:none;font-size:115%;}#subtabs strong { display:block; float: left; font-size:115%;padding:.2em .4em; margin: 0.3em 0;}#subtabs { margin-top : 1em; }a.currentsubtab { background-color:#FFC;} > </style> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >index 3d0d695af9..931e606671 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >@@ -3,7 +3,7 @@ > <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css"> >+ <style> > ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; } > #idref h2.role { > background-color: #DDDEEE; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt >index 5985b9375f..c89fb3870e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt >@@ -3,7 +3,7 @@ > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Images for: [% biblio.title |html %]</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css"> >+ <style> > #largeCoverImg { > border : 1px solid #CCCCCC; > display : block; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 4647001f7b..cf1ecd73ba 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -4,7 +4,7 @@ > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Your checkout history</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css">ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; }</style> >+ <style>ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; }</style> > [% END %] > </head> > [% INCLUDE 'bodytag.inc' bodyid='opac-readingrecord' %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt >index 7e537b601e..6e908a7893 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt >@@ -1,6 +1,6 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Comments on [% title |html %]</title> >-<style type="text/css"> >+<style> > #custom-doc { width:37.08em;*width:36.16em;min-width:485px; margin:1em auto; text-align:left; } > </style> > [% INCLUDE 'doc-head-close.inc' %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index 4deb9169fd..2c6bbc89fb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -5,7 +5,7 @@ > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Tags</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css"> >+ <style> > fieldset { padding : .3em;margin:.3em 0;} > #tagcloud {background-color: #F3F3F3; text-align: justify;padding:7px;} > .tag a {text-decoration: none;} >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >index 09fa0e3d56..5f8ba001c3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >@@ -6,7 +6,7 @@ > <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Most popular titles</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %] >- <style type="text/css"> >+ <style> > #search-facets fieldset { border: 0; margin: 0;padding:.3em;}#search-facets ol{padding:.3em;}#search-facets li {list-style-type:none;padding:4px 4px;}#search-facets label{font-weight:bold;display:block;margin:.2em 0;}#search-facets fieldset.action {padding-left:4px;margin:.3em;}; > </style> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt >index c3fd4ff9c9..83454538b1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt >@@ -7,8 +7,8 @@ > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/bootstrap/css/bootstrap.min_[% KOHA_VERSION %].css" /> > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/jquery/jquery-ui_[% KOHA_VERSION %].css" /> > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/sco_[% KOHA_VERSION %].css" /> >-[% IF ( OPACUserCSS ) %]<style type="text/css">[% OPACUserCSS %]</style>[% END %] >-[% IF ( SCOUserCSS ) %]<style type="text/css">[% SCOUserCSS %]</style>[% END %] >+[% IF ( OPACUserCSS ) %]<style>[% OPACUserCSS %]</style>[% END %] >+[% IF ( SCOUserCSS ) %]<style>[% SCOUserCSS %]</style>[% END %] > <!--[if lt IE 9]> > <script src="[% interface %]/[% theme %]/lib/respond.min.js"></script> > <![endif]--> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index cdbd52d77e..b0e9747f5c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -9,8 +9,8 @@ > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/bootstrap/css/bootstrap.min_[% KOHA_VERSION %].css" /> > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/jquery/jquery-ui_[% KOHA_VERSION %].css" /> > <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/sco_[% KOHA_VERSION %].css" /> >-[% IF ( Koha.Preference('OPACUserCSS') ) %]<style type="text/css">[% Koha.Preference('OPACUserCSS') %]</style>[% END %] >-[% IF ( Koha.Preference('SCOUserCSS') ) %]<style type="text/css">[% Koha.Preference('SCOUserCSS') %]</style>[% END %] >+[% IF ( Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') %]</style>[% END %] >+[% IF ( Koha.Preference('SCOUserCSS') ) %]<style>[% Koha.Preference('SCOUserCSS') %]</style>[% END %] > <!--[if lt IE 9]> > <script src="[% interface %]/[% theme %]/lib/respond.min.js"></script> > <![endif]--> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20054
:
70787
|
70798
|
70979
|
71027
| 71499