Bugzilla – Attachment 71517 Details for
Bug 18403
Hide patron information if not part of the logged in user library group
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18403: Add new method Koha::Patron->can_see_patrons_from
Bug-18403-Add-new-method-KohaPatron-canseepatronsf.patch (text/plain), 2.10 KB, created by
Jonathan Druart
on 2018-02-12 19:34:42 UTC
(
hide
)
Description:
Bug 18403: Add new method Koha::Patron->can_see_patrons_from
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-02-12 19:34:42 UTC
Size:
2.10 KB
patch
obsolete
>From 38ae35332a60da74a69afb8765f8f2f3e870c11d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 7 Apr 2017 14:00:34 -0300 >Subject: [PATCH] Bug 18403: Add new method Koha::Patron->can_see_patrons_from > >Technical note: >Sometimes we do not have the patron object, for instance for the patron modifications >we will need to know if the logged in user can modify patron's from a given library. >This new subroutine 'can_see_patrons_from' will then be useful > >Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan@ptfs-europe.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/Patron.pm | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 24bb8e5bdc..0d7cca43c2 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -720,14 +720,27 @@ Return true if the patron (usually the logged in user) can see the patron's info > > sub can_see_patron_infos { > my ( $self, $patron ) = @_; >+ return $self->can_see_patrons_from( $patron->library->branchcode ); >+} >+ >+=head3 can_see_patrons_from >+ >+my $can_see = $patron->can_see_patrons_from( $branchcode ); >+ >+Return true if the patron (usually the logged in user) can see the patron's infos from a given library >+ >+=cut >+ >+sub can_see_patrons_from { >+ my ( $self, $branchcode ) = @_; > my $can = 0; >- if ( $self->branchcode eq $patron->branchcode ) { >+ if ( $self->branchcode eq $branchcode ) { > $can = 1; > } elsif ( $self->can( { borrowers => 'view_borrower_infos_from_any_libraries' } ) ) { > $can = 1; > } elsif ( my $library_groups = $self->library->library_groups ) { > while ( my $library_group = $library_groups->next ) { >- if ( $library_group->parent->has_child( $patron->library->branchcode ) ) { >+ if ( $library_group->parent->has_child( $branchcode ) ) { > $can = 1; > last; > } >@@ -777,6 +790,7 @@ sub libraries_where_can_see_patrons { > } > } > } >+ > return sort(uniq(@restricted_branchcodes)); > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18403
:
62010
|
62011
|
62012
|
62013
|
62014
|
62015
|
62016
|
62017
|
62018
|
62019
|
62020
|
62021
|
62022
|
62023
|
62024
|
62025
|
62026
|
62027
|
62028
|
62029
|
62030
|
62031
|
62032
|
62033
|
62302
|
62303
|
62830
|
62831
|
62832
|
62833
|
62834
|
62835
|
62836
|
62837
|
62838
|
62839
|
62840
|
62841
|
62842
|
62843
|
62844
|
62845
|
62846
|
62847
|
62848
|
62849
|
62850
|
62851
|
62852
|
62853
|
62854
|
62855
|
71392
|
71394
|
71500
|
71501
|
71502
|
71503
|
71504
|
71505
|
71506
|
71507
|
71508
|
71509
|
71510
|
71511
|
71512
|
71513
|
71514
|
71515
|
71516
| 71517 |
71518
|
71519
|
71520
|
71521
|
71522
|
71523
|
71524
|
71525
|
71526
|
71527
|
71528
|
71529
|
71530
|
71767