Attachment 71523 Details for Bug 18403 – Bug 18403: REST API - patrons endpoint

[patch] Bug 18403: REST API - patrons endpoint

Bug-18403-REST-API---patrons-endpoint.patch (text/plain), 2.20 KB, created by Jonathan Druart on 2018-02-12 19:35:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-02-12 19:35:13 UTC

Size: 2.20 KB

patch

obsolete

>From 5c8365e4a748a6e3eadddccc44a196087d4da279 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 10 Apr 2017 17:34:34 -0300
>Subject: [PATCH] Bug 18403: REST API - patrons endpoint
>
>There is something wrond here, the userenv is no set and so we cannot
>user search_limited.
>Should we set the userenv or filter on the libraries using
>libraries_where_can_see_patrons?
>WAITING FOR FEEDBACK HERE.
>
>Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan@ptfs-europe.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/REST/V1/Patron.pm            | 3 ++-
> api/v1/swagger/paths/holds.json   | 2 +-
> api/v1/swagger/paths/patrons.json | 4 ++--
> 3 files changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/REST/V1/Patron.pm b/Koha/REST/V1/Patron.pm
>index 7cc7bedffc..8fbe4587e3 100644
>--- a/Koha/REST/V1/Patron.pm
>+++ b/Koha/REST/V1/Patron.pm
>@@ -24,7 +24,8 @@ use Koha::Patrons;
> sub list {
>     my $c = shift->openapi->valid_input or return;
> 
>-    my $patrons = Koha::Patrons->search;
>+    # FIXME The limited does not work here, the userenv is not set
>+    my $patrons = Koha::Patrons->search_limited;
> 
>     return $c->render(status => 200, openapi => $patrons);
> }
>diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json
>index adf1178c70..6bbcd40850 100644
>--- a/api/v1/swagger/paths/holds.json
>+++ b/api/v1/swagger/paths/holds.json
>@@ -154,7 +154,7 @@
>         "allow-owner": true,
>         "allow-guarantor": true,
>         "permissions": {
>-          "borrowers": "1"
>+          "borrowers": "edit_borrowers"
>         }
>       }
>     },
>diff --git a/api/v1/swagger/paths/patrons.json b/api/v1/swagger/paths/patrons.json
>index 204ccdf10b..565d20c26e 100644
>--- a/api/v1/swagger/paths/patrons.json
>+++ b/api/v1/swagger/paths/patrons.json
>@@ -44,7 +44,7 @@
>       },
>       "x-koha-authorization": {
>         "permissions": {
>-          "borrowers": "1"
>+          "borrowers": "edit_borrowers"
>         }
>       }
>     }
>@@ -103,7 +103,7 @@
>         "allow-owner": true,
>         "allow-guarantor": true,
>         "permissions": {
>-          "borrowers": "1"
>+          "borrowers": "edit_borrowers"
>         }
>       }
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18403: 62010 | 62011 | 62012 | 62013 | 62014 | 62015 | 62016 | 62017 | 62018 | 62019 | 62020 | 62021 | 62022 | 62023 | 62024 | 62025 | 62026 | 62027 | 62028 | 62029 | 62030 | 62031 | 62032 | 62033 | 62302 | 62303 | 62830 | 62831 | 62832 | 62833 | 62834 | 62835 | 62836 | 62837 | 62838 | 62839 | 62840 | 62841 | 62842 | 62843 | 62844 | 62845 | 62846 | 62847 | 62848 | 62849 | 62850 | 62851 | 62852 | 62853 | 62854 | 62855 | 71392 | 71394 | 71500 | 71501 | 71502 | 71503 | 71504 | 71505 | 71506 | 71507 | 71508 | 71509 | 71510 | 71511 | 71512 | 71513 | 71514 | 71515 | 71516 | 71517 | 71518 | 71519 | 71520 | 71521 | 71522 | 71523 | 71524 | 71525 | 71526 | 71527 | 71528 | 71529 | 71530 | 71767