Bugzilla – Attachment 71529 Details for
Bug 18403
Hide patron information if not part of the logged in user library group
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18403: Fix perlcritic on Koha::Patron
Bug-18403-Fix-perlcritic-on-KohaPatron.patch (text/plain), 996 bytes, created by
Jonathan Druart
on 2018-02-12 20:42:12 UTC
(
hide
)
Description:
Bug 18403: Fix perlcritic on Koha::Patron
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-02-12 20:42:12 UTC
Size:
996 bytes
patch
obsolete
>From edeb7db0de4eba7562d9aeff55c4a1707e214fc3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 12 Feb 2018 17:35:53 -0300 >Subject: [PATCH] Bug 18403: Fix perlcritic on Koha::Patron > >Perl::Critic found these violations in "Koha/Patron.pm": >"return" statement followed by "sort" at line 798, column 5. Behavior >is undefined if called in scalar context. (Severity: 5) >--- > Koha/Patron.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index b017d43006..40c8c88574 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -795,7 +795,8 @@ sub libraries_where_can_see_patrons { > > @restricted_branchcodes = grep { defined $_ } @restricted_branchcodes; > @restricted_branchcodes = uniq(@restricted_branchcodes); >- return sort (@restricted_branchcodes); >+ @restricted_branchcodes = sort(@restricted_branchcodes); >+ return @restricted_branchcodes; > } > > sub has_permission { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18403
:
62010
|
62011
|
62012
|
62013
|
62014
|
62015
|
62016
|
62017
|
62018
|
62019
|
62020
|
62021
|
62022
|
62023
|
62024
|
62025
|
62026
|
62027
|
62028
|
62029
|
62030
|
62031
|
62032
|
62033
|
62302
|
62303
|
62830
|
62831
|
62832
|
62833
|
62834
|
62835
|
62836
|
62837
|
62838
|
62839
|
62840
|
62841
|
62842
|
62843
|
62844
|
62845
|
62846
|
62847
|
62848
|
62849
|
62850
|
62851
|
62852
|
62853
|
62854
|
62855
|
71392
|
71394
|
71500
|
71501
|
71502
|
71503
|
71504
|
71505
|
71506
|
71507
|
71508
|
71509
|
71510
|
71511
|
71512
|
71513
|
71514
|
71515
|
71516
|
71517
|
71518
|
71519
|
71520
|
71521
|
71522
|
71523
|
71524
|
71525
|
71526
|
71527
|
71528
| 71529 |
71530
|
71767