Attachment 71564 Details for Bug 20144 – Bug 20144: (follow-up) Adjust /patrons endpoint

[patch] Bug 20144: (follow-up) Adjust /patrons endpoint

Bug-20144-follow-up-Adjust-patrons-endpoint.patch (text/plain), 1.49 KB, created by Tomás Cohen Arazi (tcohen) on 2018-02-13 18:56:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-02-13 18:56:43 UTC

Size: 1.49 KB

patch

obsolete

>From 91c725b1ea3bf28ef58e1eb371bc43a80d923581 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 13 Feb 2018 15:52:45 -0300
>Subject: [PATCH] Bug 20144: (follow-up) Adjust /patrons endpoint
>
>Fields 'address' and 'city' have been maybe nullable by this bug. This
>patch makes them nullable on the API as well.
>
>To test:
>- Run:
>  $ kshell
> k$ prove t/db_dependent/api/v1/patrons.t
>=> FAIL: Tests fail (randomly) when address or city are set to null by
>         TestBuilder.
>- Apply this patch
>- Run:
> k$ prove t/db_dependent/api/v1/patrons.t
>=> SUCCESS: Tests pass!
>- Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> api/v1/swagger/definitions/patron.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/api/v1/swagger/definitions/patron.json b/api/v1/swagger/definitions/patron.json
>index 735454f80b..2c6f9a6a34 100644
>--- a/api/v1/swagger/definitions/patron.json
>+++ b/api/v1/swagger/definitions/patron.json
>@@ -34,7 +34,7 @@
>       "description": "street type of patron's primary address"
>     },
>     "address": {
>-      "type": "string",
>+      "type": ["string", "null"],
>       "description": "first address line of patron's primary address"
>     },
>     "address2": {
>@@ -42,7 +42,7 @@
>       "description": "second address line of patron's primary address"
>     },
>     "city": {
>-      "type": "string",
>+      "type": ["string", "null"],
>       "description": "city or town of patron's primary address"
>     },
>     "state": {
>-- 
>2.16.1

Actions: View | Diff | Splinter Review

Attachments on bug 20144: 71410 | 71411 | 71412 | 71413 | 71414 | 71415 | 71416 | 71417 | 71418 | 71419 | 71420 | 71421 | 71422 | 71423 | 71424 | 71425 | 71427 | 71428 | 71429 | 71430 | 71431 | 71432 | 71434 | 71435 | 71436 | 71437 | 71438 | 71440 | 71441 | 71442 | 71443 | 71444 | 71445 | 71446 | 71447 | 71448 | 71449 | 71450 | 71451 | 71452 | 71453 | 71454 | 71455 | 71456 | 71457 | 71458 | 71459 | 71460 | 71461 | 71462 | 71463 | 71467 | 71564