Bugzilla – Attachment 71659 Details for
Bug 19996
use Modern::Perl in cataloguing perl scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19996: (RM follow-up) Remove commented use warnings;
Bug-19996-RM-follow-up-Remove-commented-use-warnin.patch (text/plain), 4.38 KB, created by
Jonathan Druart
on 2018-02-15 14:22:11 UTC
(
hide
)
Description:
Bug 19996: (RM follow-up) Remove commented use warnings;
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-02-15 14:22:11 UTC
Size:
4.38 KB
patch
obsolete
>From 8322fc1f979e47cd1b725b764f42b0bfc4694f69 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 15 Feb 2018 11:20:34 -0300 >Subject: [PATCH] Bug 19996: (RM follow-up) Remove commented use warnings; > >These plugins are very noisy, badly written and I have no idea what they >do. >t/db_dependent/FrameworkPlugin.t outputs a log of warnings about " >uninitialized value". > >Let fix them later. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > cataloguing/value_builder/unimarc_field_105.pl | 3 ++- > cataloguing/value_builder/unimarc_field_110.pl | 3 ++- > cataloguing/value_builder/unimarc_field_120.pl | 3 ++- > cataloguing/value_builder/unimarc_field_130.pl | 3 ++- > cataloguing/value_builder/unimarc_field_140.pl | 3 ++- > cataloguing/value_builder/unimarc_field_225a.pl | 4 ++-- > cataloguing/value_builder/unimarc_field_4XX.pl | 3 ++- > 7 files changed, 14 insertions(+), 8 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl >index caf0c6c484..0afc26f2cc 100755 >--- a/cataloguing/value_builder/unimarc_field_105.pl >+++ b/cataloguing/value_builder/unimarc_field_105.pl >@@ -18,7 +18,8 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use Modern::Perl; >+use strict; >+#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl >index 72e87d091e..547b4087bd 100755 >--- a/cataloguing/value_builder/unimarc_field_110.pl >+++ b/cataloguing/value_builder/unimarc_field_110.pl >@@ -18,7 +18,8 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use Modern::Perl; >+use strict; >+#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_120.pl b/cataloguing/value_builder/unimarc_field_120.pl >index fbd03e1899..50abed84fe 100755 >--- a/cataloguing/value_builder/unimarc_field_120.pl >+++ b/cataloguing/value_builder/unimarc_field_120.pl >@@ -18,7 +18,8 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use Modern::Perl; >+use strict; >+#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_130.pl b/cataloguing/value_builder/unimarc_field_130.pl >index ec1904fbd2..ab23ad8e83 100755 >--- a/cataloguing/value_builder/unimarc_field_130.pl >+++ b/cataloguing/value_builder/unimarc_field_130.pl >@@ -18,7 +18,8 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use Modern::Perl; >+use strict; >+#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_140.pl b/cataloguing/value_builder/unimarc_field_140.pl >index f64c23ffcd..bcdb24481e 100755 >--- a/cataloguing/value_builder/unimarc_field_140.pl >+++ b/cataloguing/value_builder/unimarc_field_140.pl >@@ -18,7 +18,8 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use Modern::Perl; >+use strict; >+#use warnings; FIXME - Bug 2505 > > use Koha::Util::FrameworkPlugin qw(wrapper); > use C4::Auth; >diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl >index 1c645a65c0..0e0dca7dcd 100755 >--- a/cataloguing/value_builder/unimarc_field_225a.pl >+++ b/cataloguing/value_builder/unimarc_field_225a.pl >@@ -39,8 +39,8 @@ It need : > > =cut > >-use Modern::Perl; >- >+use strict; >+#use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); > use C4::Context; >diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl >index 8bfe89abba..c51434954c 100755 >--- a/cataloguing/value_builder/unimarc_field_4XX.pl >+++ b/cataloguing/value_builder/unimarc_field_4XX.pl >@@ -18,7 +18,8 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > >-use Modern::Perl; >+use strict; >+#use warnings; FIXME - Bug 2505 > > use CGI qw ( -utf8 ); > use C4::Output; >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=71659">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19996
:
70672
|
70884
|
71194
|
71195
|
71196
| 71659 |
71660