Attachment 71675 Details for Bug 20216 – Bug 20216: Correctly populate values in itemtype editor

[patch] Bug 20216: Correctly populate values in itemtype editor

Bug-20216-Correctly-populate-values-in-itemtype-ed.patch (text/plain), 3.29 KB, created by Owen Leonard on 2018-02-15 17:57:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2018-02-15 17:57:44 UTC

Size: 3.29 KB

patch

obsolete

>From 5f70c967b11a709e6af744e4054465c1a4f93b73 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 15 Feb 2018 17:05:29 +0000
>Subject: [PATCH] Bug 20216: Correctly populate values in itemtype editor
>
>To test:
>1 - Edit an item type, define a replacement cost,processing fee, and
>remote image url
>2 - Save the item type
>3 - Values are correct in list
>4 - Edit again
>5 - note values in fields are not populated
>6 - Save itemtype, values are lost
>7 - Apply patch
>8 - Repeat 1-4
>9 - Values should be correctly populated and saved now
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>index 183e4f0..a4bd9dd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>@@ -195,14 +195,14 @@ Item types administration
>                         <ul>
>                             <li>
>                                 <label for="remote_image_check"> Remote image:</label>
>-                                [% IF remote_image %]
>+                                [% IF itemtype.imageurl %]
>                                     <input type="radio" id="remote_image_check" name="image" value="remoteImage" checked="checked" />
>                                 [% ELSE %]
>                                     <input type="radio" id="remote_image_check" name="image" value="remoteImage" />
>                                 [% END %]
>-                                <input type="text" name="remoteImage" size="48" maxlength="200" value="[% remote_image %]" onmousedown="document.getElementById('remote_image_check').checked = true;" />
>+                                <input type="text" name="remoteImage" size="48" maxlength="200" value="[% itemtype.imageurl %]" onmousedown="document.getElementById('remote_image_check').checked = true;" />
>                                 [% IF ( remote_image ) %]
>-                                    <img src="[% remote_image %]" alt="" />
>+                                    <img src="[% itemtype.imageurl %]" alt="" />
>                                 [% END %]
>                             </li>
>                         </ul>
>@@ -235,11 +235,11 @@ Item types administration
>                 </li>
>                 <li>
>                     <label for="defaultreplacecost">Default replacement cost: </label>
>-                    <input type="text" id="defaultreplacecost" name="defaultreplacecost" size="10" value="[% defaultreplacecost %]" />
>+                    <input type="text" id="defaultreplacecost" name="defaultreplacecost" size="10" value="[% itemtype.defaultreplacecost %]" />
>                 </li>
>                 <li>
>                     <label for="processfee">Processing fee (when lost): </label>
>-                    <input type="text" id="processfee" name="processfee" size="10" value="[% processfee %]" />
>+                    <input type="text" id="processfee" name="processfee" size="10" value="[% itemtype.processfee %]" />
>                 </li>
>                 <li>
>                     <label for="checkinmsg">Checkin message: </label>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20216: 71672 | 71675 | 71678 | 71693