Attachment 71697 Details for Bug 20205 – Bug 20205: Add IDs to buttons in patron-toolbar.inc

[patch] Bug 20205: Add IDs to buttons in patron-toolbar.inc

Bug-20205-Add-IDs-to-buttons-in-patron-toolbarinc.patch (text/plain), 2.88 KB, created by Katrin Fischer on 2018-02-16 06:29:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2018-02-16 06:29:22 UTC

Size: 2.88 KB

patch

obsolete

>From 28621b131f9b32395a6cb8c6e6532ecd2453fe35 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Thu, 15 Feb 2018 10:14:56 +0100
>Subject: [PATCH] Bug 20205: Add IDs to buttons in patron-toolbar.inc
>
>The buttons in patron-toolbar.inc lack unique IDs, making them
>hard to style/remove with CSS. This patch adds IDs to all three
>buttons.
>
>To test:
>- Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>  and verify there are no IDs
>- Apply the patch and look at the file again to verify the IDs have
>  been added
>- Test the "New patron" and "Quick add new patron" buttons to verify
>  they still work as intended
>- Check that the new buttons are globally unique:
>  $ grep -rn "new-patron-button" *
>  $ grep -rn "patron-lists-button" *
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>index c76953d798..147ff110f7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>@@ -5,14 +5,14 @@
> 
> [% UNLESS ( no_add ) %]
> <div id="toolbar" class="btn-toolbar">
>-    <div class="btn-group">
>+    <div class="btn-group" id="new-patron-button">
>         <button class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> New patron <span class="caret"></span></button>
>             <ul class="dropdown-menu">
>                 [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&amp;categorycode=[% category.categorycode %]">[% category.description |html %]</a></li>[% END %]
>             </ul>
>     </div>
>     [% IF Koha.Preference('PatronQuickAddFields') || Koha.Preference('BorrowerMandatoryField') %]
>-    <div class="btn-group">
>+    <div class="btn-group" id="quick-add-new-patron-button">
>         <button class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> Quick add new patron <span class="caret"></span></button>
>             <ul class="dropdown-menu">
>                 [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add&amp;categorycode=[% category.categorycode %]&amp;quickadd=true">[% category.description |html %]</a></li>[% END %]
>@@ -20,7 +20,7 @@
>     </div>
>     [% END %]
>     [% IF CAN_user_tools_manage_patron_lists %]
>-        <a class="btn btn-default btn-sm" href="/cgi-bin/koha/patron_lists/lists.pl"><i class="fa fa-edit"></i> Patron lists</a>
>+        <a class="btn btn-default btn-sm" href="/cgi-bin/koha/patron_lists/lists.pl" id="patron-lists-button"><i class="fa fa-edit"></i> Patron lists</a>
>     [% END %]
> 
> </div>
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 20205: 71641 | 71658 | 71696 | 71697