Bugzilla – Attachment 71712 Details for
Bug 20227
admin/smart-rules.pl should pass categorycode instead of branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20227: Check for categorycode in default_borrower_circ_rules
Bug-20227-Check-for-categorycode-in-defaultborrowe.patch (text/plain), 1.46 KB, created by
Marcel de Rooy
on 2018-02-16 11:05:56 UTC
(
hide
)
Description:
Bug 20227: Check for categorycode in default_borrower_circ_rules
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-02-16 11:05:56 UTC
Size:
1.46 KB
patch
obsolete
>From 323672671c0c0f24a199fc6da6a69483fab46a62 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Feb 2018 12:01:36 +0100 >Subject: [PATCH] Bug 20227: Check for categorycode in > default_borrower_circ_rules >Content-Type: text/plain; charset=utf-8 > >Fixes silent crash when adding the same category twice. >DBD::mysql::st execute failed: Duplicate entry 'ST' for key 'PRIMARY' [for Statement " > INSERT INTO default_borrower_circ_rules > (categorycode, maxissueqty, maxonsiteissueqty, max_holds) > VALUES (?, ?, ?, ?) > " with ParamValues: 0="ST", 1=undef, 2=undef, 3="3"] at /usr/share/koha/devclone/admin/smart-rules.pl line 309. > >(Line number affected by bug 15524.) > >Very trivial solution. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > admin/smart-rules.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index e9a7ad6..718b682 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -296,7 +296,7 @@ elsif ($op eq "add-branch-cat") { > maxonsiteissueqty = ? > WHERE categorycode = ? > |); >- $sth_search->execute($branch); >+ $sth_search->execute($categorycode); > my $res = $sth_search->fetchrow_hashref(); > if ($res->{total}) { > $sth_update->execute($maxissueqty, $maxonsiteissueqty, $categorycode); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20227
: 71712