Attachment 71778 Details for Bug 20176 – Bug 20176: [sql_modes] Set biblio.datecreated to NOW if not defined

[patch] Bug 20176: [sql_modes] Set biblio.datecreated to NOW if not defined

Bug-20176-sqlmodes-Set-bibliodatecreated-to-NOW-if.patch (text/plain), 2.03 KB, created by Jonathan Druart on 2018-02-16 14:26:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-02-16 14:26:13 UTC

Size: 2.03 KB

patch

obsolete

>From fcd758c1cd3285738cdf94642f8e13d30b4d1251 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 5 Feb 2018 15:59:09 -0300
>Subject: [PATCH] Bug 20176: [sql_modes] Set biblio.datecreated to NOW if not
> defined
>
>Fix at ->store level, this issue appears in lot of places.
>
>Fix for:
>Field 'datecreated' doesn't have a default value
>---
> Koha/Biblio.pm                | 14 ++++++++++++++
> t/db_dependent/Koha/Biblios.t | 15 +++++++++++++--
> 2 files changed, 27 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index a35048d21b..d226304267 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -45,6 +45,20 @@ Koha::Biblio - Koha Biblio Object class
> 
> =cut
> 
>+=head3 store
>+
>+Overloaded I<store> method to set default values
>+
>+=cut
>+
>+sub store {
>+    my ( $self ) = @_;
>+
>+    $self->datecreated( dt_from_string ) unless $self->datecreated;
>+
>+    return $self->SUPER::store;
>+}
>+
> =head3 subtitles
> 
> my @subtitles = $biblio->subtitles();
>diff --git a/t/db_dependent/Koha/Biblios.t b/t/db_dependent/Koha/Biblios.t
>index 2f807b1254..5cc286e1c1 100644
>--- a/t/db_dependent/Koha/Biblios.t
>+++ b/t/db_dependent/Koha/Biblios.t
>@@ -19,11 +19,11 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 3;
>+use Test::More tests => 4;
> 
> use C4::Reserves;
> 
>-use Koha::DateUtils qw( dt_from_string );
>+use Koha::DateUtils qw( dt_from_string output_pref );
> use Koha::Biblios;
> use Koha::Patrons;
> use Koha::Subscriptions;
>@@ -45,6 +45,17 @@ my $biblioitem = $schema->resultset('Biblioitem')->new(
>     }
> )->insert();
> 
>+subtest 'store' => sub {
>+    plan tests => 1;
>+    is(
>+        Koha::Biblios->find( $biblio->biblionumber )->datecreated,
>+        output_pref(
>+            { dt => dt_from_string, dateformat => 'iso', dateonly => 1 }
>+        ),
>+        "datecreated must be set to today if not passed to the constructor"
>+    );
>+};
>+
> subtest 'holds + current_holds' => sub {
>     plan tests => 5;
>     C4::Reserves::AddReserve( $patron->branchcode, $patron->borrowernumber, $biblio->biblionumber );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20176: 71466 | 71778 | 71814 | 71818