Bugzilla – Attachment 71803 Details for
Bug 19933
Move C4::Members::patronflags to the Koha namespace - part 1
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl
Bug-19933-Remove-patronflags---unused-vars-oldamou.patch (text/plain), 2.08 KB, created by
Jonathan Druart
on 2018-02-16 14:44:40 UTC
(
hide
)
Description:
Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-02-16 14:44:40 UTC
Size:
2.08 KB
patch
obsolete
>From ade4f87028004d67bbb4b219798a983cd23c6a20 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 7 Jan 2018 14:06:14 -0300 >Subject: [PATCH] Bug 19933: Remove patronflags - unused vars > oldamount/amountold in circulation.pl > >There is oldamound/amountold variable that is sent to the template but >never used later. Let remove it now to avoid useless replacement. >--- > circ/circulation.pl | 4 ---- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 - > 2 files changed, 5 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index ee73f6adbe..7581224565 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -555,9 +555,6 @@ foreach my $flag ( sort keys %$flags ) { > } > } > >-my $amountold = $flags ? $flags->{'CHARGES'}->{'message'} || 0 : 0; >-$amountold =~ s/^.*\$//; # remove upto the $, if any >- > my $total = $patron ? $patron->account->balance : 0; > > if ( $patron && $patron->category->category_type eq 'C') { >@@ -639,7 +636,6 @@ $template->param( > borrowernumber => $borrowernumber, > branch => $branch, > was_renewed => scalar $query->param('was_renewed') ? 1 : 0, >- amountold => $amountold, > barcodes => $barcodes, > stickyduedate => $stickyduedate, > duedatespec => $duedatespec, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index ea1389c95b..3c6a8cfe65 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -603,7 +603,6 @@ No patron matched <span class="ex">[% message | html %]</span> > <input type="hidden" name="debt_confirmed" value="[% debt_confirmed %]" /> > [% IF ( CHARGES ) %] > <input type="hidden" name="charges" value="yes" /> >- <input type="hidden" name="oldamount" value="[% amountold %]" /> > [% END %] > </fieldset> > [% IF ( issue ) %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19933
:
70347
|
70348
|
70349
|
70350
|
71803
|
71804
|
71805
|
71806
|
72004
|
72005
|
72006
|
72007
|
72094
|
72095
|
72350
|
72351
|
72352
|
72353
|
72354
|
72355
|
72356
|
72472
|
72473
|
72474
|
72475
|
72476
|
72477
|
72478