Bugzilla – Attachment 71838 Details for
Bug 18789
Send a Koha::Patron object to the templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18789: Fix perlcritic issue - housebound.pl
Bug-18789-Fix-perlcritic-issue---houseboundpl.patch (text/plain), 1.05 KB, created by
Jonathan Druart
on 2018-02-16 17:28:18 UTC
(
hide
)
Description:
Bug 18789: Fix perlcritic issue - housebound.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-02-16 17:28:18 UTC
Size:
1.05 KB
patch
obsolete
>From 77179609a228dfde3ba64985995588558a09cf31 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 16 Feb 2018 14:26:46 -0300 >Subject: [PATCH] Bug 18789: Fix perlcritic issue - housebound.pl > >"$branch" is declared but not used at line 65, column 1. Unused >variables clutter code and make it harder to read. (Severity: 3) >--- > members/housebound.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/housebound.pl b/members/housebound.pl >index 9d65f4f632..574bacdbb1 100755 >--- a/members/housebound.pl >+++ b/members/housebound.pl >@@ -62,7 +62,7 @@ my $patron = Koha::Patrons->find($borrowernumber); > output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } ); > > # Get supporting cast >-my ( $branch, $houseboundprofile, $visit ); >+my ( $houseboundprofile, $visit ); > if ( $patron ) { # FIXME This test is not needed - output_and_exit_if_error handles it > $houseboundprofile = $patron->housebound_profile; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18789
:
64211
|
64212
|
64213
|
64214
|
64215
|
64216
|
64218
|
64219
|
64221
|
64229
|
71301
|
71302
|
71303
|
71304
|
71305
|
71306
|
71307
|
71308
|
71309
|
71310
|
71311
|
71485
|
71486
|
71487
|
71488
|
71489
|
71490
|
71491
|
71492
|
71493
|
71494
|
71495
|
71496
|
71679
|
71680
|
71681
|
71682
|
71683
|
71684
|
71685
|
71686
|
71687
|
71688
|
71689
|
71690
|
71691
|
71713
|
71714
|
71715
|
71716
|
71717
|
71718
|
71719
|
71720
|
71721
|
71722
|
71723
|
71724
|
71725
|
71726
|
71727
|
71728
|
71729
|
71730
|
71731
|
71732
|
71733
|
71734
|
71735
|
71736
|
71827
| 71838 |
71841
|
73293
|
73890
|
75237