Attachment 71928 Details for Bug 20074 – Bug 20074: (Follow-up) Remove another remainder of biblio hidden logic

[patch] Bug 20074: (Follow-up) Remove another remainder of biblio hidden logic

Bug-20074-Follow-up-Remove-another-remainder-of-bi.patch (text/plain), 1.16 KB, created by Josef Moravec on 2018-02-19 09:41:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-02-19 09:41:30 UTC

Size: 1.16 KB

patch

obsolete

>From c7350988612665dbadebfcedfab65ff6466ce118 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 23 Jan 2018 15:59:06 +0100
>Subject: [PATCH] Bug 20074: (Follow-up) Remove another remainder of biblio
> hidden logic
>
>Script authorities.pl still contains a module 2 calculation on the hidden
>attribute, although it is used as a boolean.
>Since -5 mod 2 == 1, it does no harm, but we better remove it.
>
>Test plan:
>Edit and save an authority. Verify that everything still works as expected.
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> authorities/authorities.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index 7ffb010..0340277 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -187,7 +187,7 @@ sub create_input {
>     }
>     
>     $subfield_data{visibility} = "display:none;"
>-        if (    ($tagslib->{$tag}->{$subfield}->{hidden} % 2 == 1) and $value ne ''
>+        if( $tagslib->{$tag}->{$subfield}->{hidden} and $value ne ''
>             or ($value eq '' and !$tagslib->{$tag}->{$subfield}->{mandatory})
>         );
>     
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20074: 70842 | 70843 | 70847 | 71926 | 71927 | 71928 | 72191 | 72192 | 72193 | 72209 | 128400