Attachment 7195 Details for Bug 5327 – [SIGNED-OFF] bug 5327 add tests for C4/BackgroundJob.pm

[patch] [SIGNED-OFF] bug 5327 add tests for C4/BackgroundJob.pm

SIGNED-OFF-bug-5327-add-tests-for-C4BackgroundJobp.patch (text/plain), 1.95 KB, created by Katrin Fischer on 2012-01-17 06:57:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2012-01-17 06:57:21 UTC

Size: 1.95 KB

patch

obsolete

>From a8d5c4418ec036e246539c681e991d72c5003daa Mon Sep 17 00:00:00 2001
>From: Sam Sanders <sam-sanders@live.com>
>Date: Tue, 17 Jan 2012 15:37:59 +1300
>Subject: [PATCH] [SIGNED-OFF] bug 5327 add tests for C4/BackgroundJob.pm
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>perl t/db_dependent/BackgroundJob.t
>All tests complete successfully.
>
>Note: Test 11 does not tell what it's about, but it has been there before.
>---
> t/db_dependent/BackgroundJob.t |   13 ++++++++-----
> 1 files changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/BackgroundJob.t b/t/db_dependent/BackgroundJob.t
>index 8106e02..0afa315 100644
>--- a/t/db_dependent/BackgroundJob.t
>+++ b/t/db_dependent/BackgroundJob.t
>@@ -7,7 +7,7 @@ use strict;
> use warnings;
> use C4::Auth;
> use CGI;
>-use Test::More tests => 10;
>+use Test::More tests => 11;
> 
> BEGIN {
>         use_ok('C4::BackgroundJob');
>@@ -17,8 +17,8 @@ my ($userid, $cookie, $sessionID) = &checkauth($query, 1);
> #my ($sessionID, $job_name, $job_invoker, $num_work_units) = @_;
> my $background;
> diag $sessionID;
>-ok ($background=C4::BackgroundJob->new($sessionID));
>-ok ($background->id);
>+ok ($background=C4::BackgroundJob->new($sessionID), "making job");
>+ok ($background->id, "fetching id number");
> 
> $background->name("George");
> is ($background->name, "George", "testing name");
>@@ -29,12 +29,15 @@ is ($background->invoker, "enjoys", "testing invoker");
> $background->progress("testing");
> is ($background->progress, "testing", "testing progress");
> 
>-ok ($background->status);
>+ok ($background->status, "testing status");
> 
> $background->size("56");
> is ($background->size, "56", "testing size");
> 
>+ok (!$background->fetch($sessionID, $background->id), "testing fetch");
>+
>+
> $background->finish("finished");
> is ($background->status,'completed', "testing finished");
> 
>-ok ($background->results); # Will return undef unless finished
>\ No newline at end of file
>+ok ($background->results); #Will return undef unless finished
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 5327: 2716 | 2726 | 5485 | 6236 | 6237 | 6373 | 6560 | 6561 | 6562 | 6563 | 6613 | 6614 | 6616 | 6620 | 6621 | 6622 | 6643 | 6650 | 6655 | 6679 | 6681 | 6682 | 6683 | 6726 | 6727 | 6728 | 6729 | 6730 | 6731 | 6732 | 6795 | 6799 | 6805 | 6819 | 6826 | 6827 | 6828 | 6834 | 7179 | 7180 | 7181 | 7182 | 7183 | 7184 | 7185 | 7186 | 7187 | 7188 | 7189 | 7190 | 7191 | 7192 | 7194 | 7195 | 7203 | 7206 | 7208 | 7209 | 7220 | 7221 | 7222 | 7223 | 7224 | 7225 | 7226 | 7227 | 7228 | 7229 | 7230 | 7231 | 7232 | 7233 | 7234 | 7235 | 7236 | 7237 | 7238 | 7239 | 7240 | 7241 | 7242 | 7400 | 7402 | 7403 | 7405 | 7573 | 7592 | 7593 | 7594 | 9897 | 10234 | 10616 | 10656 | 10659 | 10660 | 10661 | 10680 | 11141 | 11186 | 11212 | 11213 | 11278 | 11279 | 11280 | 11281 | 11339 | 11340 | 11341 | 11440 | 11467 | 11469 | 11470 | 11471 | 11472 | 11473 | 11500 | 11503 | 11505 | 11506 | 11633 | 11762 | 11763 | 11764 | 11765 | 11846 | 11985 | 11993 | 12002 | 12003