Bugzilla – Attachment 72186 Details for
Bug 20276
GetCourseItem is using the wrong call to get itemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20276: Fix GetCourseItem call to get itemnumber
Bug-20276-Fix-GetCourseItem-call-to-get-itemnumber.patch (text/plain), 1.58 KB, created by
Josef Moravec
on 2018-02-25 10:25:08 UTC
(
hide
)
Description:
Bug 20276: Fix GetCourseItem call to get itemnumber
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-02-25 10:25:08 UTC
Size:
1.58 KB
patch
obsolete
>From dd53f88bd33986df4d37d5d107874fe45bd03330 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 23 Feb 2018 11:41:10 +0100 >Subject: [PATCH] Bug 20276: Fix GetCourseItem call to get itemnumber > >In 17.05.x : >In course_reserves/add_items.pl we now get the item via Objects. >This line: > 66 my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); >Should be: > 66 my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); > >This is corrected since 17.11 by : >Bug 18276: Remove GetBiblioFromItemNumber - Course reserves > >Test plan : >1) Create a course reserve and add items. >2) Correct information must be displayed on the detail page of the course >reserve, on staff and OPAC interface. >3) Try to add a non existing barcode, you get the page with a message > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > course_reserves/add_items.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/course_reserves/add_items.pl b/course_reserves/add_items.pl >index 0149045..faa78df 100755 >--- a/course_reserves/add_items.pl >+++ b/course_reserves/add_items.pl >@@ -62,8 +62,8 @@ if ( !$item && $action eq 'lookup' ){ > > $template->param( course => GetCourse($course_id) ); > >-if ( $action eq 'lookup' ) { >- my $course_item = GetCourseItem( itemnumber => $item->{'itemnumber'} ); >+if ( $action eq 'lookup' and $item ) { >+ my $course_item = GetCourseItem( itemnumber => $item->itemnumber ); > my $course_reserve = > ($course_item) > ? GetCourseReserve( >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20276
:
72110
|
72113
| 72186