Attachment 72275 Details for Bug 20296 – Bug 20296: Untranslatable "All" in patrons table filter

[patch] Bug 20296: Untranslatable "All" in patrons table filter

Bug-20296-Untranslatable-All-in-patrons-table-filt.patch (text/plain), 1.61 KB, created by Jonathan Druart on 2018-02-27 16:56:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-02-27 16:56:35 UTC

Size: 1.61 KB

patch

obsolete

>From 348fd052830c8fabed72cd4f679bc506f26b07f0 Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>Date: Mon, 26 Feb 2018 12:08:27 +0200
>Subject: [PATCH] Bug 20296: Untranslatable "All" in patrons table filter
>
>There's an untranslatable "All" in the "Show X entries" filter
>when browsing the patrons.
>
>Test plan:
>
>1) Home --> Patrons --> Browse by last name.
>2) In the table filtering toolbar, there's a dropdown with
>   "Show [20] entries" and the last in the dropdown is "All".
>3) Update and install a language, check that msgid "All" is
>   translated and isn't fuzzy.
>4) Check the "All" in the dropdown, it is not translated.
>5) Install patch, repeat 1-3, and check the "All" in the dropdown,
>   it should now be translated.
>
>Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index dcb3723e31..b40bb0337f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -370,7 +370,7 @@
>             $(aLengthMenu).each(function(){
>                 if ( this == -1 ) {
>                     // Label for -1 is "All"
>-                    aLengthMenuLabel.push("All");
>+                    aLengthMenuLabel.push(_("All"));
>                 } else {
>                     aLengthMenuLabel.push(this);
>                 }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20296: 72197 | 72275