Attachment 72278 Details for Bug 20301 – Bug 20301: Allow translating "View" in manage MARC import

[patch] Bug 20301: Allow translating "View" in manage MARC import

Bug-20301-Allow-translating-View-in-manage-MARC-im.patch (text/plain), 2.29 KB, created by Jonathan Druart on 2018-02-27 16:58:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2018-02-27 16:58:28 UTC

Size: 2.29 KB

patch

obsolete

>From ee33f6f8cc94e2a1213f804c39ed4c060dae2e5e Mon Sep 17 00:00:00 2001
>From: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>Date: Tue, 27 Feb 2018 09:10:17 +0200
>Subject: [PATCH] Bug 20301: Allow translating "View" in manage MARC import
>
>When looking at the table showing the staged MARC records, the "View"
>text in the Diff-column is not translatable. Make it so.
>
>Test plan:
>
>1) Go to Home -> Tools -> Stage MARC records for import
>2) Select eg. t/db_dependent/www/data/marc21record.mrc and upload the file
>3) Click on Stage for import
>   -> Manage staged records
>   -> Import this batch into the catalog
>4) Wait for zebra to reindex, or trigger it yourself by
>   running rebuild_zebra.pl -a -b -r
>5) Go to Home -> Tools -> Stage MARC records for import
>6) Select the same file as in part 2 and upload the file
>7) Change the Record matching rule to ISBN (020$a)
>8) Click on Stage for import
>   -> Manage staged records
>9) In the table below, there should now be a line showing
>   the staged MARC record matches biblio
>10) Note the "View"-text in the "Diff"-column
>11) Apply patch
>12) Install a language, view the same batch in the
>    Manage staged MARC records -page in that language
>13) The "View" should show up correctly, and if the
>    msgid "View" was translated in the xx-YY-staff-prog.po,
>    should show up in the correct language
>
>Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
>index 404bb0fa47..21cd576aa2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
>@@ -468,7 +468,7 @@
>                       }
>                       if (aData['diff_url']){
>                           $('td:eq(5)', nRow).html(
>-                              '<a href="'+aData['diff_url']+'">View</a>'
>+                              '<a href="'+aData['diff_url']+'">' + _("View") + '</a>'
>                           );
>                       }
>                       $('td:eq(6)', nRow).html(
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20301: 72251 | 72278