Bugzilla – Attachment 72282 Details for
Bug 18786
Add ability to create custom payment types
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18786: Remove use of Koha::Patron::Images
Bug-18786-Remove-use-of-KohaPatronImages.patch (text/plain), 2.40 KB, created by
Kyle M Hall (khall)
on 2018-02-27 19:05:10 UTC
(
hide
)
Description:
Bug 18786: Remove use of Koha::Patron::Images
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-02-27 19:05:10 UTC
Size:
2.40 KB
patch
obsolete
>From f56d20466698b2b8a6c3fbb96fd472dbeab71592 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatetsolutions.com> >Date: Tue, 27 Feb 2018 14:04:56 -0500 >Subject: [PATCH] Bug 18786: Remove use of Koha::Patron::Images > >--- > C4/SIP/ILS.pm | 39 ++++++++++++++------------------------- > members/paycollect.pl | 1 - > 2 files changed, 14 insertions(+), 26 deletions(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 1bd23c6..1152b7a 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -436,31 +436,20 @@ sub renew { > return $trans; > } > >- # Previously: renewing a title, rather than an item (sort of) >- # This is gross, but in a real ILS it would be better >- >- # if (defined($title_id)) { >- # foreach my $i (@{$patron->{items}}) { >- # $item = new ILS::Item $i; >- # last if ($title_id eq $item->title_id); >- # $item = undef; >- # } >- # } else { >- my $j = 0; >- my $count = scalar @{$patron->{items}}; >- foreach my $i (@{$patron->{items}}) { >- unless (defined $i->{barcode}) { # FIXME: using data instead of objects may violate the abstraction layer >- syslog("LOG_ERR", "No barcode for item %s of %s: $item_id", $j+1, $count); >- next; >- } >- syslog("LOG_DEBUG", "checking item %s of %s: $item_id vs. %s", ++$j, $count, $i->{barcode}); >- if ($i->{barcode} eq $item_id) { >- # We have it checked out >- $item = C4::SIP::ILS::Item->new( $item_id ); >- last; >- } >- } >- # } >+ my $j = 0; >+ my $count = scalar @{$patron->{items}}; >+ foreach my $i (@{$patron->{items}}) { >+ unless (defined $i->{barcode}) { # FIXME: using data instead of objects may violate the abstraction layer >+ syslog("LOG_ERR", "No barcode for item %s of %s: $item_id", $j+1, $count); >+ next; >+ } >+ syslog("LOG_DEBUG", "checking item %s of %s: $item_id vs. %s", ++$j, $count, $i->{barcode}); >+ if ($i->{barcode} eq $item_id) { >+ # We have it checked out >+ $item = C4::SIP::ILS::Item->new( $item_id ); >+ last; >+ } >+ } > > $trans->item($item); > >diff --git a/members/paycollect.pl b/members/paycollect.pl >index 9a3ca21..2f0c1f9 100755 >--- a/members/paycollect.pl >+++ b/members/paycollect.pl >@@ -30,7 +30,6 @@ use C4::Accounts; > use C4::Koha; > > use Koha::Patrons; >-use Koha::Patron::Images; > use Koha::Patron::Categories; > use Koha::AuthorisedValues; > use Koha::Account; >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18786
:
64202
|
64203
|
64204
|
64288
|
64300
|
64301
|
64302
|
67476
|
67477
|
69155
|
69156
|
69157
|
71020
|
71021
|
72015
|
72016
|
72114
|
72115
|
72282
|
73628
|
74147
|
74148
|
74149
|
74172
|
74436
|
75401