Attachment 72296 Details for Bug 16357 – Bug 16357: (follow-up) Log and timestamp fatal errors

[patch] Bug 16357: (follow-up) Log and timestamp fatal errors

Bug-16357-follow-up-Log-and-timestamp-fatal-errors.patch (text/plain), 1.58 KB, created by Mason James on 2018-02-28 23:58:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mason James

Created: 2018-02-28 23:58:38 UTC

Size: 1.58 KB

patch

obsolete

>From aaf5ac571871e9dac70a1fdfc5e7568e508dc01a Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Thu, 1 Mar 2018 12:55:18 +1300
>Subject: [PATCH] Bug 16357: (follow-up) Log and timestamp fatal errors
>Content-Type: text/plain; charset="utf-8"
>
>---
> debian/templates/plack.psgi | 6 ++----
> misc/plack/koha.psgi        | 6 ++----
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
>diff --git a/debian/templates/plack.psgi b/debian/templates/plack.psgi
>index 90d4a26..36cc4df 100644
>--- a/debian/templates/plack.psgi
>+++ b/debian/templates/plack.psgi
>@@ -41,10 +41,8 @@ use Koha::DateUtils;
> use Log::Log4perl qw(:easy);
> Log::Log4perl->easy_init({ level => $WARN, utf8 => 1 });
> my $logger = Log::Log4perl->get_logger(); # use the default logger style
>-$SIG{__WARN__} = sub {
>-    my $message = shift;
>-    $logger->warn($message);
>-};
>+$SIG{__WARN__} = sub { $logger->warn(shift) };
>+$SIG{__DIE__}  = sub { $logger->fatal(shift) };
> 
> use CGI qw(-utf8 ); # we will loose -utf8 under plack, otherwise
> {
>diff --git a/misc/plack/koha.psgi b/misc/plack/koha.psgi
>index 8f87dfb..2211ade 100644
>--- a/misc/plack/koha.psgi
>+++ b/misc/plack/koha.psgi
>@@ -9,10 +9,8 @@ use Plack::App::Directory;
> use Log::Log4perl qw(:easy);
> Log::Log4perl->easy_init({ level => $WARN, utf8 => 1 });
> my $logger = Log::Log4perl->get_logger(); # use the default logger style
>-$SIG{__WARN__} = sub {
>-    my $message = shift;
>-    $logger->warn($message);
>-};
>+$SIG{__WARN__} = sub { $logger->warn(shift) };
>+$SIG{__DIE__}  = sub { $logger->fatal(shift) };
> 
> use CGI qw(-utf8 ); # we will lose -utf8 under plack
> {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16357: 71752 | 71753 | 71871 | 72290 | 72296 | 73404 | 77529 | 77530 | 77531 | 77532 | 77533 | 106141 | 106313 | 106319 | 106320 | 109053 | 109054 | 109055 | 109056 | 109060 | 109067 | 109068 | 109133 | 109215 | 110107 | 110108 | 110109 | 110249 | 110250 | 110251 | 110252 | 110253 | 110254