Attachment 72349 Details for Bug 18958 – Bug 18958: (Follow-up) Pass patron to template for confirm hold

[patch] Bug 18958: (Follow-up) Pass patron to template for confirm hold

Bug-18958-Follow-up-Pass-patron-to-template-for-co.patch (text/plain), 1.22 KB, created by Marcel de Rooy on 2018-03-02 11:13:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2018-03-02 11:13:19 UTC

Size: 1.22 KB

patch

obsolete

>From 4cf4fbc5234b6e6b3f12c473580b50765b223257 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 2 Mar 2018 11:10:46 +0100
>Subject: [PATCH] Bug 18958: (Follow-up) Pass patron to template for confirm
> hold
>Content-Type: text/plain; charset=utf-8
>
>Removing the FIXME. Trivial fix.
>Not sure where to put it; can be moved on its own.
>
>Test plan:
>Confirm a hold and verify that patron details are shown in popup.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> circ/returns.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 34b52cc..e5d164f 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -432,9 +432,8 @@ if ( $messages->{'ResFound'}) {
> 
>         # same params for Waiting or Reserved
>         $template->param(
>-            # FIXME The full patron object should be passed to the template
>+            patron         => $patron,
>             found          => 1,
>-            name           => $patron->surname . ", " . $patron->title . " " . $patron->firstname,
>             barcode        => $barcode,
>             destbranch     => $reserve->{'branchcode'},
>             borrowernumber => $reserve->{'borrowernumber'},
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18958: 65104 | 65150 | 65184 | 71164 | 71232 | 72210 | 72211 | 72348 | 72349 | 92159 | 92160 | 93106 | 93107 | 93108 | 93111 | 93112 | 93113 | 93216 | 93217 | 93218 | 107576 | 107577 | 107582 | 107584 | 107585 | 107586 | 108256 | 108274 | 108473 | 108474 | 108497 | 108499 | 108500 | 108936 | 108937 | 109061 | 109222 | 109640 | 109641 | 109642 | 109643 | 109644 | 109645