Bugzilla – Attachment 72457 Details for
Bug 11317
Add a way to access files from the intranet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11317: Update ID to allow for permalinking
Bug-11317-Update-ID-to-allow-for-permalinking.patch (text/plain), 2.22 KB, created by
Josef Moravec
on 2018-03-06 07:13:57 UTC
(
hide
)
Description:
Bug 11317: Update ID to allow for permalinking
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-03-06 07:13:57 UTC
Size:
2.22 KB
patch
obsolete
>From 603a7b32a25d247d17259aaf501da9ccda508ed4 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 25 Apr 2014 11:56:04 +0200 >Subject: [PATCH] Bug 11317: Update ID to allow for permalinking > >This follow up modifies the id parameter to use a digest of the >filename to enable permalinking to files even if the array order >changes due to new files being created. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > reports/report_files.pl | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/reports/report_files.pl b/reports/report_files.pl >index 06221ce..3976ecb 100755 >--- a/reports/report_files.pl >+++ b/reports/report_files.pl >@@ -29,6 +29,7 @@ use C4::Context; > use C4::Output; > use C4::Koha; > use File::stat; >+use Digest::MD5 qw(md5_hex); > > my $input = new CGI; > my $file_id = $input->param("id"); >@@ -50,8 +51,8 @@ else { > my @files_list; > opendir(DIR, $directory); > >- my $i=0; > foreach my $filename (readdir(DIR)) { >+ my $id = md5_hex($filename); > my $full_path = "$directory/$filename"; > next if ($filename =~ /^\./ or -d $full_path); > >@@ -59,14 +60,14 @@ else { > push(@files_list, {name => $filename, > date => scalar localtime($st->mtime), > size => $st->size, >- id => $i}); >- $i++; >+ id => $id}); > } > closedir(DIR); > >+ my %files_hash = map { $_->{id} => $_ } @files_list; > # If we received a file_id and it is valid, send the file to the browser >- if(defined $file_id and $file_id >= 0 and $file_id < scalar @files_list){ >- my $filename = $files_list[$file_id]->{name}; >+ if(defined $file_id and $file_id >= 0 and exists $files_hash{$file_id} ){ >+ my $filename = $files_hash{$file_id}->{name}; > binmode STDOUT; > # Open the selected file and send it to the browser > print $input->header(-type => 'application/x-download', >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11317
:
23203
|
25387
|
27492
|
27579
|
27604
|
35938
|
35939
|
35940
|
36844
|
39783
|
39784
|
39785
|
39786
|
44859
|
44860
|
48629
|
48635
|
49941
|
49942
|
49943
|
49944
|
49945
|
49946
|
49947
|
50421
|
50424
|
50425
|
50440
|
53446
|
58220
|
58221
|
58222
|
58223
|
58224
|
58225
|
58226
|
62971
|
62972
|
62973
|
62974
|
62975
|
64088
|
64089
|
65691
|
65851
|
65855
|
65856
|
65857
|
65909
|
65910
|
65911
|
65912
|
65913
|
65914
|
65915
|
65918
|
66091
|
66092
|
66093
|
66094
|
66095
|
66096
|
66097
|
66098
|
66099
|
66100
|
72097
|
72309
|
72456
|
72457
|
72458
|
72459
|
72460
|
72461
|
72462
|
72463
|
72464
|
72465
|
74119
|
74379
|
74756
|
74911
|
74912
|
74916
|
74917
|
74918
|
74919
|
75019