Bugzilla – Attachment 72497 Details for
Bug 20347
Add missing classes to search results elements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20347: Add missing classes to search results elements
0001-Bug-20347-Add-missing-classes-to-search-results-elem.patch (text/plain), 3.71 KB, created by
paxed
on 2018-03-07 07:41:23 UTC
(
hide
)
Description:
Bug 20347: Add missing classes to search results elements
Filename:
MIME Type:
Creator:
paxed
Created:
2018-03-07 07:41:23 UTC
Size:
3.71 KB
patch
obsolete
>From a37fd508eaa64ac534d2388e0d1cc59c98eb0cea Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@joensuu.fi> >Date: Wed, 7 Mar 2018 09:35:19 +0200 >Subject: [PATCH] Bug 20347: Add missing classes to search results elements > >The MARC21 XSLT doesn't add html classes to distinguish between >certain elements, and there's no way to rely on the element >positioning, making it impossible to style the elements with CSS. > >Add the missing classes to distinguish the elements. > >Test plan: >1) Apply patch >2) Search for any biblios >3) Check the search result page table HTML to see that the > "Publisher", "Edition", "Source", "Other title", and "Online access" > are wrapped in a span with class of results_summary and one > of "publisher", "edition", "source", "other_title", and > "online_access" >4) Check that the search results of the elements above looks correct > when compared to the other elements > >Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> >--- > .../prog/en/xslt/MARC21slim2intranetResults.xsl | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >index 0e8ebd6d31..3e508c048c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl >@@ -829,7 +829,7 @@ > <xsl:call-template name="m880Select"> > <xsl:with-param name="basetags">260</xsl:with-param> > <xsl:with-param name="codes">abcg</xsl:with-param> >- <xsl:with-param name="class">results_summary</xsl:with-param> >+ <xsl:with-param name="class">results_summary publisher</xsl:with-param> > <xsl:with-param name="label">Publisher: </xsl:with-param> > </xsl:call-template> > </xsl:if> >@@ -915,7 +915,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=250]"> >- <span class="results_summary"> >+ <span class="results_summary edition"> > <span class="label">Edition: </span> > <xsl:for-each select="marc:datafield[@tag=250]"> > <xsl:call-template name="subfieldSelect"> >@@ -928,7 +928,7 @@ > <xsl:if test="marc:datafield[@tag=773]"> > <xsl:for-each select="marc:datafield[@tag=773]"> > <xsl:if test="marc:subfield[@code='t']"> >- <span class="results_summary"> >+ <span class="results_summary source"> > <span class="label">Source: </span> > <xsl:value-of select="marc:subfield[@code='t']"/> > </span> >@@ -941,13 +941,13 @@ > <xsl:call-template name="m880Select"> > <xsl:with-param name="basetags">246</xsl:with-param> > <xsl:with-param name="codes">ab</xsl:with-param> >- <xsl:with-param name="class">results_summary</xsl:with-param> >+ <xsl:with-param name="class">results_summary other_title</xsl:with-param> > <xsl:with-param name="label">Other title: </xsl:with-param> > </xsl:call-template> > </xsl:if> > > <xsl:if test="marc:datafield[@tag=246]"> >- <span class="results_summary"> >+ <span class="results_summary other_title"> > <span class="label">Other title: </span> > <xsl:for-each select="marc:datafield[@tag=246]"> > <xsl:call-template name="subfieldSelect"> >@@ -959,7 +959,7 @@ > </span> > </xsl:if> > <xsl:if test="marc:datafield[@tag=856]"> >- <span class="results_summary"> >+ <span class="results_summary online_access"> > <span class="label">Online access: </span> > <xsl:for-each select="marc:datafield[@tag=856]"> > <xsl:variable name="SubqText"><xsl:value-of select="marc:subfield[@code='q']"/></xsl:variable> >-- >2.11.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20347
:
72497
|
72826
|
73070