Attachment 72535 Details for Bug 20167 – Bug 20167: Make changing a hold pass the itemnumber to ModReserve

[patch] Bug 20167: Make changing a hold pass the itemnumber to ModReserve

Bug-20167-Make-changing-a-hold-pass-the-itemnumber.patch (text/plain), 1.31 KB, created by Josef Moravec on 2018-03-08 12:45:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2018-03-08 12:45:03 UTC

Size: 1.31 KB

patch

obsolete

>From 4529468e1cf44d88e56cd872b724d37c13554424 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Mon, 5 Mar 2018 13:36:50 -0300
>Subject: [PATCH] Bug 20167: Make changing a hold pass the itemnumber to
> ModReserve
>
>If you have an item-level hold, changing an attribute (like priority,
>pickup location or suspended until date) makes the hold a biblio-level
>hold, because ModReserve is not passed the current itemnumber.
>
>This patch uses the hold's itemnumber and passes it to the ModReserve
>call.
>
>To test:
>- Run the regression tests from the previous patch:
>  $ kshell
> k$ prove t/db_dependent/api/v1/holds.t
>=> FAIL: Tests fail
>- Apply this patch
>- Run the tests:
>  $ kshell
> k$ prove t/db_dependent/api/v1/holds.t
>=> SUCCESS: Tests pass!
>- Sign off :-D
>
>Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> Koha/REST/V1/Hold.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/REST/V1/Hold.pm b/Koha/REST/V1/Hold.pm
>index 2927a7a..2833f39 100644
>--- a/Koha/REST/V1/Hold.pm
>+++ b/Koha/REST/V1/Hold.pm
>@@ -144,6 +144,7 @@ sub edit {
>         branchcode => $branchcode,
>         rank => $priority,
>         suspend_until => $suspend_until,
>+        itemnumber => $hold->itemnumber
>     };
> 
>     C4::Reserves::ModReserve($params);
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20167: 72436 | 72437 | 72479 | 72480 | 72534 | 72535