Bugzilla – Attachment 72546 Details for
Bug 20103
Readonly::XS version not detected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20103: Remove Readonly::XS from PerlDependencies
Bug-20103-Remove-ReadonlyXS-from-PerlDependencies.patch (text/plain), 1.42 KB, created by
Marcel de Rooy
on 2018-03-09 06:58:39 UTC
(
hide
)
Description:
Bug 20103: Remove Readonly::XS from PerlDependencies
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-03-09 06:58:39 UTC
Size:
1.42 KB
patch
obsolete
>From cf129b6156dc965c135f14dd69b2b43db1166ed3 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 30 Jan 2018 18:25:13 +0000 >Subject: [PATCH] Bug 20103: Remove Readonly::XS from PerlDependencies >Content-Type: text/plain; charset=utf-8 > >While having Readonly::XS is a good thing on slower systems >the CPAN page for Readonly says it isn't required to be >used directly, so we don't need to check for it. > >Additionally, even reading /usr/share/perl5/Readonly.pm you >see "# Modern perl doesn't need Readonly::XS" on an if >statement checking for version 5.8! Koha requires 5.20 >(see C4::Log::cronlogaction's use of caller). > >TEST PLAN >--------- >Can you run a fresh install? >Does the about page list Readonly::XS? It shouldn't after the patch. >Run koha qa test tools > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Installer/PerlDependencies.pm | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm >index 8961453..2a7a99a 100644 >--- a/C4/Installer/PerlDependencies.pm >+++ b/C4/Installer/PerlDependencies.pm >@@ -852,11 +852,6 @@ our $PERL_DEPS = { > 'required' => '0', > 'min_ver' => '0.01' > }, >- 'Readonly::XS' => { >- 'usage' => 'Make script happy', >- 'required' => '0', >- 'min_ver' => '0.01' >- }, > 'Bytes::Random::Secure' => { > usage => 'Core', > required => 1, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20103
:
71071
|
72546
|
73406
|
73407
|
73879
|
74695