Bugzilla – Attachment 72561 Details for
Bug 20341
Show authorized value description for withdrawn like damaged and lost
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20341: Show authorized value description for withdrawn like damaged and lost
Bug-20341-Show-authorized-value-description-for-wi.patch (text/plain), 3.96 KB, created by
Kyle M Hall (khall)
on 2018-03-09 11:43:44 UTC
(
hide
)
Description:
Bug 20341: Show authorized value description for withdrawn like damaged and lost
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-03-09 11:43:44 UTC
Size:
3.96 KB
patch
obsolete
>From e22d806c830c00c98f8fe0a5a3605adf91342a74 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 6 Mar 2018 12:26:19 +0100 >Subject: [PATCH] Bug 20341: Show authorized value description for withdrawn > like damaged and lost > >Actually catalog detail page shows for damaged and lost items the authorized value description if exists. >We must do the same for withdrawn information. > >Test plan : >1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN' >2) Edit the authorized value category to add value '2' and description 'Eaten by dog' >3) Edit an item to set this withdrawn value >4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl : >=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' >5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl : >=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' > >Signed-off-by: delaye <stephane.delaye@biblibre.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > catalogue/detail.pl | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 10 +++++++++- > koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc | 7 ++++++- > 3 files changed, 19 insertions(+), 2 deletions(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index 58d4511..704c595 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -211,6 +211,10 @@ $mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => > if ( $mss->count ) { > $template->param( itemdamagedloop => GetAuthorisedValues( $mss->next->authorised_value ) ); > } >+$mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.withdrawn', authorised_value => { not => undef } }); >+if ( $mss->count ) { >+ $template->param( itemwithdrawnloop => GetAuthorisedValues( $mss->next->authorised_value) ); >+} > > $mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => { not => undef } }); > my %materials_map; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 3640a9c..d3b12b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -406,7 +406,15 @@ > [% END %] > > [% IF ( item.withdrawn ) %] >- <span class="wdn">Withdrawn</span> >+ [% IF itemwithdrawnloop %] >+ [% FOREACH itemwithdrawnloo IN itemwithdrawnloop %] >+ [% IF itemwithdrawnloo.authorised_value == item.withdrawn %] >+ <span class="wdn">[% itemwithdrawnloo.lib %]</span> >+ [% END %] >+ [% END %] >+ [% ELSE %] >+ <span class="wdn">Withdrawn</span> >+ [% END %] > [% END %] > > [% IF ( item.damaged ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc >index ffb4d52..7fd4fd2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc >@@ -53,7 +53,12 @@ > > [% IF ( item.withdrawn ) %] > [% SET itemavailable = 0 %] >- <span class="item-status withdrawn">Item withdrawn</span> >+ [% av_lib_include = AuthorisedValues.GetByCode( 'WITHDRAWN', item.withdrawn, 1 ) %] >+ [% IF av_lib_include %] >+ <span class="item-status withdrawn">[% av_lib_include %]</span> >+ [% ELSE %] >+ <span class="item-status withdrawn">Item withdrawn</span> >+ [% END %] > [% END %] > > >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20341
:
72468
|
72470
| 72561 |
72562
|
72563