Attachment 72582 Details for Bug 18606 – Bug 18606: Get rid of isItemInAnyCollection

[patch] Bug 18606: Get rid of isItemInAnyCollection

Bug-18606-Get-rid-of-isItemInAnyCollection.patch (text/plain), 2.32 KB, created by Kyle M Hall (khall) on 2018-03-09 13:03:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-03-09 13:03:17 UTC

Size: 2.32 KB

patch

obsolete

>From 902fcff1ea35f40bbac95c9db07e981e150f143a Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Wed, 17 May 2017 12:40:46 +0000
>Subject: [PATCH] Bug 18606: Get rid of isItemInAnyCollection
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Circulation.pm         |  4 ++--
> C4/RotatingCollections.pm | 28 ----------------------------
> 2 files changed, 2 insertions(+), 30 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index ae55d7f..b8987a9 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -35,7 +35,6 @@ use C4::Message;
> use C4::Debug;
> use C4::Log; # logaction
> use C4::Overdues qw(CalcFine UpdateFine get_chargeable_units);
>-use C4::RotatingCollections;
> use Algorithm::CheckDigits;
> 
> use Data::Dumper;
>@@ -56,6 +55,7 @@ use Koha::RefundLostItemFeeRule;
> use Koha::RefundLostItemFeeRules;
> use Koha::Account::Lines;
> use Koha::Account::Offsets;
>+use Koha::RotatingCollection::Trackings;
> use Carp;
> use List::MoreUtils qw( uniq );
> use Scalar::Util qw( looks_like_number );
>@@ -1938,7 +1938,7 @@ sub AddReturn {
>     my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->{'itemnumber'} );
> 
>     # if we have a transfer to do, we update the line of transfers with the datearrived
>-    my $is_in_rotating_collection = C4::RotatingCollections::isItemInAnyCollection( $item->{'itemnumber'} );
>+    my $is_in_rotating_collection = Koha::RotatingCollection::Trackings->search( { itemnumber => $item->{'itemnumber'} } )->count;
>     if ($datesent) {
>         if ( $tobranch eq $branch ) {
>             my $sth = C4::Context->dbh->prepare(
>diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
>index 7a97cdb..0848c76 100644
>--- a/C4/RotatingCollections.pm
>+++ b/C4/RotatingCollections.pm
>@@ -51,34 +51,6 @@ BEGIN {
>     );
> }
> 
>-=head2 isItemInAnyCollection
>-
>-$inCollection = isItemInAnyCollection( $itemnumber );
>-
>-=cut
>-
>-sub isItemInAnyCollection {
>-    my ($itemnumber) = @_;
>-
>-    my $dbh = C4::Context->dbh;
>-
>-    my $sth = $dbh->prepare(
>-        "SELECT itemnumber FROM collections_tracking WHERE itemnumber = ?");
>-    $sth->execute($itemnumber) or return (0);
>-
>-    my $row = $sth->fetchrow_hashref;
>-
>-    $itemnumber = $row->{itemnumber};
>-    if ($itemnumber) {
>-        return 1;
>-    }
>-    else {
>-        return 0;
>-    }
>-}
>-
>-1;
>-
> __END__
> 
> =head1 AUTHOR
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 18606: 63508 | 63509 | 63510 | 63511 | 63512 | 63513 | 63514 | 63515 | 63516 | 63517 | 63518 | 63519 | 63520 | 63521 | 63522 | 63523 | 63524 | 63525 | 63526 | 63527 | 63528 | 66227 | 66228 | 66229 | 66230 | 66231 | 66232 | 66233 | 66234 | 66235 | 66236 | 66237 | 66238 | 66239 | 66240 | 66241 | 66286 | 66287 | 66288 | 66289 | 66290 | 66291 | 66292 | 66293 | 66294 | 66295 | 66296 | 66297 | 66298 | 66299 | 66300 | 67734 | 67735 | 67736 | 67737 | 67738 | 67739 | 67740 | 67741 | 67742 | 67743 | 67744 | 67745 | 67746 | 67747 | 67748 | 67749 | 68428 | 68429 | 68430 | 68431 | 68432 | 68433 | 68434 | 68435 | 68436 | 68437 | 68438 | 68439 | 68440 | 68441 | 68442 | 68443 | 69709 | 69710 | 69711 | 69712 | 69713 | 69714 | 69715 | 69716 | 69717 | 69718 | 69719 | 69720 | 69721 | 69722 | 69723 | 69759 | 72416 | 72417 | 72418 | 72419 | 72420 | 72421 | 72422 | 72423 | 72424 | 72425 | 72426 | 72427 | 72428 | 72429 | 72430 | 72431 | 72572 | 72573 | 72574 | 72575 | 72576 | 72577 | 72578 | 72579 | 72580 | 72581 | 72582 | 72583 | 72584 | 72585 | 72586 | 72587 | 72816 | 79141 | 79142 | 79143 | 79144 | 79145 | 79146 | 79147 | 79148 | 79149 | 79150 | 79151 | 79152 | 79153 | 79154 | 79155 | 79156 | 79157 | 79158 | 79161