Attachment 72587 Details for Bug 18606 – Bug 18606: (Follow-up) Make QA tools happy

[patch] Bug 18606: (Follow-up) Make QA tools happy

Bug-18606-Follow-up-Make-QA-tools-happy.patch (text/plain), 1.64 KB, created by Kyle M Hall (khall) on 2018-03-09 13:03:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-03-09 13:03:38 UTC

Size: 1.64 KB

patch

obsolete

>From c06faf11a84fe857c2d463f7500d7fb77b960a50 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Wed, 13 Dec 2017 06:43:44 +0000
>Subject: [PATCH] Bug 18606: (Follow-up) Make QA tools happy
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/RotatingCollection.pm           | 3 ++-
> Koha/RotatingCollection/Trackings.pm | 4 ++++
> Koha/RotatingCollections.pm          | 4 ++++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/RotatingCollection.pm b/Koha/RotatingCollection.pm
>index 7e4c2ef..51e7b72 100644
>--- a/Koha/RotatingCollection.pm
>+++ b/Koha/RotatingCollection.pm
>@@ -136,7 +136,8 @@ sub transfer {
> 
>     $self->colBranchcode( $library->branchcode )->store;
> 
>-    my $from = C4::Context->userenv->{'branch'} if C4::Context->userenv;
>+    my $from;
>+    $from = C4::Context->userenv->{'branch'} if C4::Context->userenv;
> 
>     my $items = $self->items;
>     while ( my $item = $items->next ) {
>diff --git a/Koha/RotatingCollection/Trackings.pm b/Koha/RotatingCollection/Trackings.pm
>index 0c6fe32..bcd0b80 100644
>--- a/Koha/RotatingCollection/Trackings.pm
>+++ b/Koha/RotatingCollection/Trackings.pm
>@@ -45,6 +45,10 @@ sub _type {
>     return 'CollectionsTracking';
> }
> 
>+=head3 object_class
>+
>+=cut
>+
> sub object_class {
>     return 'Koha::RotatingCollection::Tracking';
> }
>diff --git a/Koha/RotatingCollections.pm b/Koha/RotatingCollections.pm
>index 255930f..a0e9914 100644
>--- a/Koha/RotatingCollections.pm
>+++ b/Koha/RotatingCollections.pm
>@@ -45,6 +45,10 @@ sub _type {
>     return 'Collection';
> }
> 
>+=head3 object_class
>+
>+=cut
>+
> sub object_class {
>     return 'Koha::RotatingCollection';
> }
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 18606: 63508 | 63509 | 63510 | 63511 | 63512 | 63513 | 63514 | 63515 | 63516 | 63517 | 63518 | 63519 | 63520 | 63521 | 63522 | 63523 | 63524 | 63525 | 63526 | 63527 | 63528 | 66227 | 66228 | 66229 | 66230 | 66231 | 66232 | 66233 | 66234 | 66235 | 66236 | 66237 | 66238 | 66239 | 66240 | 66241 | 66286 | 66287 | 66288 | 66289 | 66290 | 66291 | 66292 | 66293 | 66294 | 66295 | 66296 | 66297 | 66298 | 66299 | 66300 | 67734 | 67735 | 67736 | 67737 | 67738 | 67739 | 67740 | 67741 | 67742 | 67743 | 67744 | 67745 | 67746 | 67747 | 67748 | 67749 | 68428 | 68429 | 68430 | 68431 | 68432 | 68433 | 68434 | 68435 | 68436 | 68437 | 68438 | 68439 | 68440 | 68441 | 68442 | 68443 | 69709 | 69710 | 69711 | 69712 | 69713 | 69714 | 69715 | 69716 | 69717 | 69718 | 69719 | 69720 | 69721 | 69722 | 69723 | 69759 | 72416 | 72417 | 72418 | 72419 | 72420 | 72421 | 72422 | 72423 | 72424 | 72425 | 72426 | 72427 | 72428 | 72429 | 72430 | 72431 | 72572 | 72573 | 72574 | 72575 | 72576 | 72577 | 72578 | 72579 | 72580 | 72581 | 72582 | 72583 | 72584 | 72585 | 72586 | 72587 | 72816 | 79141 | 79142 | 79143 | 79144 | 79145 | 79146 | 79147 | 79148 | 79149 | 79150 | 79151 | 79152 | 79153 | 79154 | 79155 | 79156 | 79157 | 79158 | 79161