Bugzilla – Attachment 72610 Details for
Bug 18382
action_logs entry for module HOLDS, action SUSPEND is spammy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18382: action_logs entry for module HOLDS, action SUSPEND is spammy
Bug-18382-actionlogs-entry-for-module-HOLDS-action.patch (text/plain), 1.32 KB, created by
Kyle M Hall (khall)
on 2018-03-09 15:07:51 UTC
(
hide
)
Description:
Bug 18382: action_logs entry for module HOLDS, action SUSPEND is spammy
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2018-03-09 15:07:51 UTC
Size:
1.32 KB
patch
obsolete
>From 3c2150a5aedcbdf9d7b2ab52c7328fa87138bdbc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 5 Jun 2017 10:46:45 -0400 >Subject: [PATCH] Bug 18382: action_logs entry for module HOLDS, action SUSPEND > is spammy > >When a hold is suspended, 'suspend_until' is represented as a DateTime object, complete with locale. All told, this is about 800 lines of text. > >Test Plan: >1) Enable the HoldsLog syspref >2) Add a hold on a record/item >3) Suspend the hold with a date to resume >4) Note the massive amount of date in the suspend_until field >5) Apply this patch >6) Suspend another hold with a date to resume >7) Note the log has an acutal date in the suspend_until field > >Check the logs using module 'Holds' and Action 'Suspend' > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Hold.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 949770d..56780f8 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -91,8 +91,11 @@ sub suspend_hold { > } > > $self->suspend(1); >- $self->suspend_until( $dt ); >- >+ if ( defined $dt ){ >+ $self->suspend_until( $dt->ymd ); >+ } else { >+ $self->suspend_until( $dt ); >+ } > $self->store(); > > logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, Dumper($self->unblessed) ) >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18382
:
61842
|
63962
|
68281
|
68363
|
68364
|
72610
|
73149
|
73150
|
73317
|
73343
|
73420