Attachment 72620 Details for Bug 20282 – Bug 20282: Match course reserve on holdingbranch

[patch] Bug 20282: Match course reserve on holdingbranch

Bug-20282-Match-course-reserve-on-holdingbranch.patch (text/plain), 1.94 KB, created by Maksim Sen on 2018-03-09 20:16:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Maksim Sen

Created: 2018-03-09 20:16:56 UTC

Size: 1.94 KB

patch

obsolete

>From f6bb0240c626e72388706f0f48c7daab2d1da1ab Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 23 Feb 2018 10:58:27 +0000
>Subject: [PATCH] Bug 20282: Match course reserve on holdingbranch
>
>To test:
>1 - Add a course (Course Reserves)
>2 - Add an item to the course
>3 - Ensure to change the holding branch for the course reserve
>4 - Modify the course item
>5 - Note the dropdwn for holding branch is unset
>6 - Apply patch
>7 - Modify the course item
>8 - Dropdown should be correctly populated
>
>Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
>---
> .../intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt    | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>index 7960ff4..9389d57 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
>@@ -84,7 +84,7 @@
>                         <select id="holdingbranch" name="holdingbranch">
>                             <option value="">LEAVE UNCHANGED</option>
>                             [% FOREACH b IN Branches.all() %]
>-                                [% IF course_item.holdingbranch && ( ( course.enabled == 'yes' && b.value == item.holdingbranch ) || ( course.enabled == 'no' && b.value == course_item.holdingbranch ) ) %]
>+                                [% IF course_item.holdingbranch && ( ( course.enabled == 'yes' && b.branchcode == item.holdingbranch ) || ( course.enabled == 'no' && b.branchcode == course_item.holdingbranch ) ) %]
>                                     <option value="[% b.branchcode %]" selected="selected">[% b.branchname %]</option>
>                                 [% ELSE %]
>                                     <option value="[% b.branchcode %]">[% b.branchname %]</option>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 20282: 72112 | 72620 | 73416