Attachment 72690 Details for Bug 18593 – Bug 18593: Move suggestions when bibliographic records are merged

[patch] Bug 18593: Move suggestions when bibliographic records are merged

Bug-18593-Move-suggestions-when-bibliographic-reco.patch (text/plain), 2.40 KB, created by Biblibre Sandboxes on 2018-03-12 14:18:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2018-03-12 14:18:32 UTC

Size: 2.40 KB

patch

obsolete

>From 7a546f5cc321da127e988d7f4d2a6436c0084ab5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 2 Jan 2018 15:42:12 -0300
>Subject: [PATCH] Bug 18593: Move suggestions when bibliographic records are
> merged
>
>When bibliographic records are merged, the suggestions.biblionumber
>field should be replaced with the new record.
>Ideally we should have kept an history of the merges, to know what was
>the original record. Now we cannot fix the broken links.
>
>Test plan:
>1) Create a suggestion in OPAC
>2) Accept the suggestion in staff
>3) Add order from this suggestion
>4) Go to cataloguing search and search for the record and another
>5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists)
>6) Verify that after merging, the new title displays in the acquisition record
>7) Verify that the suggestion info no longer displays in basket
>
>From Katrin's test plan:
>8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated)
>=> This is the title from suggestions.title, I think it makes sense to show this one.
>Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record
>
>Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr>
>---
> cataloguing/merge.pl | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/cataloguing/merge.pl b/cataloguing/merge.pl
>index 4594671..896f924 100755
>--- a/cataloguing/merge.pl
>+++ b/cataloguing/merge.pl
>@@ -111,6 +111,9 @@ if ($merge) {
>     my $sth_serial = $dbh->prepare("
>         UPDATE serial SET biblionumber = ? WHERE biblionumber = ?
>     ");
>+    my $sth_suggestions = $dbh->prepare("
>+        UPDATE suggestions SET biblionumber = ? WHERE biblionumber = ?
>+    ");
> 
>     my $report_header = {};
>     foreach my $biblionumber ($ref_biblionumber, @biblionumbers) {
>@@ -155,7 +158,10 @@ if ($merge) {
>         }
> 
>     # Moving serials
>-        $sth_serial->execute($ref_biblionumber, $biblionumber);
>+    $sth_serial->execute($ref_biblionumber, $biblionumber);
>+
>+    # Moving suggestions
>+    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
> 
>     # Moving orders (orders linked to items of frombiblio have already been moved by MoveItemFromBiblio)
>     my @allorders = GetOrdersByBiblionumber($biblionumber);
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18593: 70233 | 72690 | 73159