Bugzilla – Attachment 72707 Details for
Bug 20195
Untranslatable Show/Hide title attr replacement in opac detail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail
Bug-20195-Untranslatable-ShowHide-title-attr-repla.patch (text/plain), 3.90 KB, created by
Katrin Fischer
on 2018-03-12 15:27:33 UTC
(
hide
)
Description:
Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-03-12 15:27:33 UTC
Size:
3.90 KB
patch
obsolete
>From 47bf78eeb091569946bf7889e34a77cb7d891420 Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@joensuu.fi> >Date: Wed, 14 Feb 2018 12:12:52 +0200 >Subject: [PATCH] Bug 20195: Untranslatable Show/Hide title attr replacement in > opac detail > >There's javascript code in opac detail view that tries to replace >the word "Show" with "Hide" (and vice versa) in a title attribute. >In addition to those words being untranslatable, a word replacement >like that would not work properly when using other languages. > >Replace the single title attribute with two translatable strings, >one for the "Show" case and one "Hide", and use the whole >string instead of trying to replace a single word. > >Test plan: > >1) Make sure OpacBrowseResults is on >2) in OPAC, search the catalog and go to the detail view >3) Hover the mouse over the "Browse results" text in the grey box on the > right side. The popup text should show something like > "Show pagination list (1-5 / 5)" >4) Click on the "Browse results" >5) Hover the mouse again over the text. The popup should show > "Hide pagination list (1-5 / 5)" >6) Update a language xx-YY, translate the new msgids > "Show pagination list (%s-%s / %s)" and > "Hide pagination list (%s-%s / %s)", and install the language >7) Repeat 2-5 with that language, making sure the popup > texts show up correctly in that language > >Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 3372637aca..4801f90313 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1098,7 +1098,7 @@ > <div class="nav_results"> > <div class="l_Results"> > [% IF ( listResults ) %] >- <a href="#" id="a_listResults" title="Show pagination list ([% indexPag %]-[% indexPagEnd %] / [% totalPag %])">Browse results</a> >+ <a href="#" id="a_listResults">Browse results</a> > [% ELSE %] > <span>Browse results</span> > [% END %] >@@ -1568,8 +1568,12 @@ > [% END %] > > [% IF ( OpacBrowseResults && busc ) %] >+ var list_title_showmsg = _("Show pagination list (%s-%s / %s)").format([% indexPag %], [% indexPagEnd %], [% totalPag %]); >+ var list_title_hidemsg = _("Hide pagination list (%s-%s / %s)").format([% indexPag %], [% indexPagEnd %], [% totalPag %]); > if (arrPagination.length > 0) { > renderPagIndexList(pag_index_ini, $("#listResults")); >+ var reslist = $("#a_listResults"); >+ reslist.attr('title', list_title_showmsg); > } > $("#a_listResults").click(function(e) { > if (arrPagination.length > 0) { >@@ -1577,13 +1581,11 @@ > var navigation = $(".results-pagination"); > if (navigation.css("display") == 'none') { > navigation.show(); >- var newtitle = $(this).attr('title').replace('Show', 'Hide') >- $(this).attr('title',newtitle); >+ $(this).attr('title',list_title_hidemsg); > renderPagination(pag_index_ini, arrPagination.length - 1, $("#ul_pagination_list"), false); > } else { > navigation.hide(); >- var newtitle = $(this).attr('title').replace('Hide', 'Show') >- $(this).attr('title',newtitle); >+ $(this).attr('title',list_title_showmsg); > } > } > }); >-- >2.14.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20195
:
71606
|
72627
| 72707