Bugzilla – Attachment 72745 Details for
Bug 19581
Elasticsearch - Catmandu split option adds extra null fields to indexes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19581: Remove unused comment/variable
Bug-19581-Remove-unused-commentvariable.patch (text/plain), 2.27 KB, created by
Nick Clemens (kidclamp)
on 2018-03-13 09:32:55 UTC
(
hide
)
Description:
Bug 19581: Remove unused comment/variable
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2018-03-13 09:32:55 UTC
Size:
2.27 KB
patch
obsolete
>From ee9b62768e1145d365a9b6a4117b208c731a6d5f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 13 Mar 2018 09:32:04 +0000 >Subject: [PATCH] Bug 19581: Remove unused comment/variable > >--- > Koha/SearchEngine/Elasticsearch.pm | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm >index d904bcf..f6ae2c8 100644 >--- a/Koha/SearchEngine/Elasticsearch.pm >+++ b/Koha/SearchEngine/Elasticsearch.pm >@@ -323,20 +323,14 @@ sub get_fixer_rules { > sub { > my ( $name, $type, $facet, $suggestible, $sort, $marc_type, $marc_field ) = @_; > return if $marc_type ne $marcflavour; >- my $options = ''; >- >- # There's a bug when using 'split' with something that >- # selects a range >- # The split makes everything into nested arrays, but that's not >- # really a big deal, ES doesn't mind. >- $options = '' unless $marc_field =~ m|_/| || $type eq 'sum'; >- push @rules, "marc_map('$marc_field','${name}.\$append', $options)"; >+ >+ push @rules, "marc_map('$marc_field','${name}.\$append', '')"; > if ($facet) { >- push @rules, "marc_map('$marc_field','${name}__facet.\$append', $options)"; >+ push @rules, "marc_map('$marc_field','${name}__facet.\$append', '')"; > } > if ($suggestible) { > push @rules, >- #"marc_map('$marc_field','${name}__suggestion.input.\$append', $options)"; #must not have nested data structures in .input >+ #"marc_map('$marc_field','${name}__suggestion.input.\$append', '')"; #must not have nested data structures in .input > "marc_map('$marc_field','${name}__suggestion.input.\$append')"; > } > if ( $type eq 'boolean' ) { >@@ -351,7 +345,7 @@ sub get_fixer_rules { > } > if ($self->sort_fields()->{$name}) { > if ($sort || !defined $sort) { >- push @rules, "marc_map('$marc_field','${name}__sort.\$append', $options)"; >+ push @rules, "marc_map('$marc_field','${name}__sort.\$append', '')"; > } > } > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19581
:
68947
|
68948
|
68949
|
69092
|
69093
|
72745
|
72767
|
72997
|
73864
|
73865
|
73866
|
73867
|
73896