Attachment 72768 Details for Bug 20386 – Bug 20386: Improve warning and error messages for Search Engine Configuration

[patch] Bug 20386: Improve warning and error messages for Search Engine Configuration

Bug-20386-Improve-warning-and-error-messages-for-S.patch (text/plain), 1.93 KB, created by Claire Gravely on 2018-03-13 11:20:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Claire Gravely

Created: 2018-03-13 11:20:24 UTC

Size: 1.93 KB

patch

obsolete

>From ecfc87efdbc699127196007008fd8f0cf414810e Mon Sep 17 00:00:00 2001
>From: Claire Gravely <claire.gravely@bsz-bw.de>
>Date: Tue, 13 Mar 2018 11:18:33 +0000
>Subject: [PATCH] Bug 20386: Improve warning and error messages for Search
> Engine Configuration
>
>This patch updates a warning message and error message in the Search
>engine configuration for Elasticsearch.
>
>Note: elasticsearch does not need to be active in order to test.
>
>To test warning message:
> 1. go to: cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl
> 2. note the warning message
> 3. Apply patch
> 4. Note the change in warning message. Confirm it makes sense.
>
>To test error message:
>  Apply patch and check the changed message in the template file mappings.tt and confirm it makes sense.
>---
> .../prog/en/modules/admin/searchengine/elasticsearch/mappings.tt      | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
>index 24327c5..cc6f94c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
>@@ -88,11 +88,11 @@ a.add, a.delete {
> 
>     <h1>Search engine configuration</h1>
>     <div class="warning">
>-        Warning: Any modification in these configurations will need a total reindexation to be fully taken into account !
>+        Warning: Any changes to the configuration will only take effect after a full reindex. Until then searching may not work correctly.
>     </div>
>     [% IF errors %]
>         <div class="error">
>-        Errors occurred, Modifications does not apply. Please check following values:
>+        Changes have not been applied. Please check the following values:
>           <ul>
>             [% FOREACH e IN errors %]
>                 <li>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20386: 72768 | 72833 | 73079