Bugzilla – Attachment 7280 Details for
Bug 7450
Missing placeholders in admin/authorised_values.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl
SIGNED-OFF-Bug-7450-missing-placeholders-in-author.patch (text/plain), 2.19 KB, created by
Katrin Fischer
on 2012-01-22 21:14:12 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7450: missing placeholders in authorised_values.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2012-01-22 21:14:12 UTC
Size:
2.19 KB
patch
obsolete
>From ce305edef52556565028cc05b21b1f4121c25bda Mon Sep 17 00:00:00 2001 >From: Adrien Saurat <adrien.saurat@biblibre.com> >Date: Tue, 17 Jan 2012 12:00:32 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 7450: missing placeholders in > authorised_values.pl > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Successfully added, edited and deleted authorised values. >No problems found. >--- > admin/authorised_values.pl | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/admin/authorised_values.pl b/admin/authorised_values.pl >index d7872d6..f5dbc46 100755 >--- a/admin/authorised_values.pl >+++ b/admin/authorised_values.pl >@@ -104,13 +104,13 @@ if ($op eq 'add_form') { > my $duplicate_entry = 0; > > if ( $id ) { # Update >- my $sth = $dbh->prepare( "SELECT category, authorised_value FROM authorised_values WHERE id='$id' "); >- $sth->execute(); >+ my $sth = $dbh->prepare( "SELECT category, authorised_value FROM authorised_values WHERE id = ? "); >+ $sth->execute($id); > my ($category, $authorised_value) = $sth->fetchrow_array(); > if ( $authorised_value ne $new_authorised_value ) { > my $sth = $dbh->prepare_cached( "SELECT COUNT(*) FROM authorised_values " . >- "WHERE category = '$new_category' AND authorised_value = '$new_authorised_value' and id<>$id"); >- $sth->execute(); >+ "WHERE category = ? AND authorised_value = ? and id <> ? "); >+ $sth->execute($new_category, $new_authorised_value, $id); > ($duplicate_entry) = $sth->fetchrow_array(); > warn "**** duplicate_entry = $duplicate_entry"; > } >@@ -133,8 +133,8 @@ if ($op eq 'add_form') { > } > else { # Insert > my $sth = $dbh->prepare_cached( "SELECT COUNT(*) FROM authorised_values " . >- "WHERE category = '$new_category' AND authorised_value = '$new_authorised_value' "); >- $sth->execute(); >+ "WHERE category = ? AND authorised_value = ? "); >+ $sth->execute($new_category, $new_authorised_value); > ($duplicate_entry) = $sth->fetchrow_array(); > unless ( $duplicate_entry ) { > my $sth=$dbh->prepare( 'INSERT INTO authorised_values >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7450
:
7197
|
7280
|
7281