Attachment 72899 Details for Bug 20419 – Bug 20419 - Removed updating of holdingbranch in ModItemTransfer()

[patch] Bug 20419 - Removed updating of holdingbranch in ModItemTransfer()

Bug-20419---Removed-updating-of-holdingbranch-in-M.patch (text/plain), 1.63 KB, created by Alex Buckley on 2018-03-15 01:00:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Buckley

Created: 2018-03-15 01:00:37 UTC

Size: 1.63 KB

patch

obsolete

>From 80ad6566a5c374611ffd35afc39c52b3d714ea3f Mon Sep 17 00:00:00 2001
>From: Alex Buckley <alexbuckley@catalyst.net.nz>
>Date: Tue, 13 Mar 2018 12:07:50 +0000
>Subject: [PATCH] Bug 20419 - Removed updating of holdingbranch in
> ModItemTransfer()
>
>The call to ModItem to update the holdingbranch has been removed from
>the ModItemTransfer function in C4/Items.pm this is because the
>holdingbranch should only be changed when the item is checked in at the
>destination branch not whilst it is in transit.
>
>Test plan:
>1. Ensure the system preference AutomaticItemReturn is set to 'Dont'
>
>2. Place a reserve on an item to be picked up at branch b
>
>3. Check out the item to a different patron
>
>4. Check the item back in to branch a
>
>5. Select 'Confirm hold and transfer' button in the modal box that
>appears
>
>6. Notice that the current location of the item visible on the item tab
>of the detail.pl page of the record is set as branch b even though the
>item is in transit
>
>7. Apply patch
>
>8. Restart apache2, memcached and plack (if it is enabled)
>
>9. Repeat steps 1, 2, 3, 4, 5 and notice that the current location is set
>to branch a
>
>10. Check the item in at branch b and notice that the current location
>of the item is now branch b
>
>Sponsored-By: Catalyst IT
>---
> C4/Items.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index a3ecd87..b256341 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -630,7 +630,6 @@ sub ModItemTransfer {
>         VALUES (?, ?, NOW(), ?)");
>     $sth->execute($itemnumber, $frombranch, $tobranch);
> 
>-    ModItem({ holdingbranch => $tobranch }, undef, $itemnumber);
>     ModDateLastSeen($itemnumber);
>     return;
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 20419: 72899