Bugzilla – Attachment 73028 Details for
Bug 20115
Languages appear in a different order in the footer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20115: Make the prefs sortable
Bug-20115-Make-the-prefs-sortable.patch (text/plain), 2.27 KB, created by
Jesse Maseto
on 2018-03-16 12:03:46 UTC
(
hide
)
Description:
Bug 20115: Make the prefs sortable
Filename:
MIME Type:
Creator:
Jesse Maseto
Created:
2018-03-16 12:03:46 UTC
Size:
2.27 KB
patch
obsolete
>From ae5cc54c2f2b036cef0a97a9932115ee9317fe2b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 31 Jan 2018 13:47:46 -0300 >Subject: [PATCH] Bug 20115: Make the prefs sortable > >If we depend on the order, we should make it sortable. > >I let the customization to someone else (we would need an icon to tell >the user it's sortable). > >Something does not work here: >If fr-FR and fr-CA is installed, but only 1 is ticked, it will be >considered as last. I do not think it's a blocker as it does not make >really make sense to have it installed but not used (the interface is >also weird, there is a dropdown list with only 1 entry) > >Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index b381d2a..ef4cd66 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -104,8 +104,9 @@ > <a class="collapse-textarea" style="display:none" href="#">Click to collapse</br></a> > [% END %] > [% ELSIF ( CHUNK.type_languages ) %] >- <dl> >+ <dl class="sortable"> > [% FOREACH language IN CHUNK.languages %] >+ <div> > [% IF ( language.plural ) %] > <dt> > [% IF ( language.native_description ) %][% language.native_description %][% ELSE %][% language.rfc4646_subtag %][% END %] >@@ -130,6 +131,7 @@ > [% END %] > </dt> > [% END %] >+ </div> > [% END %] > </dl> > [% END %] >@@ -160,6 +162,7 @@ > });[% END %] > > $(document).ready(function(){ >+ $("dl.sortable").sortable(); > $("select[multiple='multiple']").multipleSelect( { > placeholder: _("Please select ..."), > selectAllText: _("Select all"), >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20115
:
71094
|
71095
|
71096
|
71661
|
73027
|
73028
|
73029
|
73030
|
73433
|
73610
|
73611
|
73612
|
73613
|
73614