Bugzilla – Attachment 73063 Details for
Bug 20179
Remove GROUP BY in get_shelves_containing_record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record
Bug-20179-sqlmodes-Remove-GROUP-BY-in-getshelvesco.patch (text/plain), 974 bytes, created by
Roch D'Amour
on 2018-03-16 20:28:13 UTC
(
hide
)
Description:
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record
Filename:
MIME Type:
Creator:
Roch D'Amour
Created:
2018-03-16 20:28:13 UTC
Size:
974 bytes
patch
obsolete
>From c59a35ffc15da56e0424b0916445d6d6b32f5561 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Feb 2018 11:04:50 -0300 >Subject: [PATCH] Bug 20179: [sql_modes] Remove GROUP BY in > get_shelves_containing_record > >Replaced with distinct. >Fix for: >'koha_kohadev.me.shelfname' isn't in GROUP BY > >t/db_dependent/Virtualshelves.t > >Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> >--- > Koha/Virtualshelves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Virtualshelves.pm b/Koha/Virtualshelves.pm >index 195376c..bb7db67 100644 >--- a/Koha/Virtualshelves.pm >+++ b/Koha/Virtualshelves.pm >@@ -154,7 +154,7 @@ sub get_shelves_containing_record { > }, > { > join => [ 'virtualshelfcontents', 'virtualshelfshares' ], >- group_by => 'shelfnumber', >+ distinct => 'shelfnumber', > order_by => { -asc => 'shelfname' }, > } > ); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20179
:
71470
|
71626
|
73063
|
73861