Bugzilla – Attachment 73065 Details for
Bug 18797
t/db_dependent/rollingloans.t is skipping
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18797: Make rollingloans test useful
Bug-18797-Make-rollingloans-test-useful.patch (text/plain), 2.42 KB, created by
Mark Tompsett
on 2018-03-17 02:27:26 UTC
(
hide
)
Description:
Bug 18797: Make rollingloans test useful
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2018-03-17 02:27:26 UTC
Size:
2.42 KB
patch
obsolete
>From 4bf34107128f39282aa250f9c9c92c693a5aea40 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 17 Mar 2018 02:24:41 +0000 >Subject: [PATCH] Bug 18797: Make rollingloans test useful > >TEST PLAN >--------- >1) Run the following commands on a kohadevbox: > kshell > prove -v t/db_dependent/rollingloans.t > exit > -- all the tests were skipped, not useful! >2) Apply this patch >3) Redo step 1 > -- all the tests run >4) Run qa test tools >--- > t/db_dependent/rollingloans.t | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/rollingloans.t b/t/db_dependent/rollingloans.t >index 17ff8db..0ac7e6c 100644 >--- a/t/db_dependent/rollingloans.t >+++ b/t/db_dependent/rollingloans.t >@@ -1,3 +1,4 @@ >+#!/usr/bin/perl > > use Modern::Perl; > use C4::Context; >@@ -7,6 +8,7 @@ use C4::Items; > use Koha::DateUtils; > use Koha::Patrons; > use t::lib::TestBuilder; >+use t::lib::Mocks qw(mock_preference); > > use Test::More tests => 8; > >@@ -17,7 +19,7 @@ C4::Context->_new_userenv(1234567); > C4::Context->set_userenv(91, 'CLIstaff', '23529001223661', 'CPL', > 'CPL', 'CPL', '', 'cc@cscnet.co.uk'); > >- >+t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems',0); > my $test_patron = '23529001223651'; > my $test_item_fic = '502326000402'; > my $test_item_24 = '502326000404'; >@@ -25,7 +27,24 @@ my $test_item_48 = '502326000403'; > > my $builder = t::lib::TestBuilder->new; > my $borrower1 = $builder->build_object({ class => 'Koha::Patrons', value => { cardnumber => $test_patron } }); >-my $item1 = GetItem (undef,$test_item_fic); >+my $item1 = $builder->build_object({ >+ class => 'Koha::Items', >+ value => { >+ barcode => $test_item_fic, >+ } >+}); >+my $item2 = $builder->build_object({ >+ class => 'Koha::Items', >+ value => { >+ barcode => $test_item_24, >+ } >+}); >+my $item3 = $builder->build_object({ >+ class => 'Koha::Items', >+ value => { >+ barcode => $test_item_48, >+ } >+}); > > SKIP: { > skip 'Missing test borrower or item, skipping tests', 8 >@@ -49,7 +68,7 @@ sub try_issue { > my $patron = Koha::Patrons->find( { cardnumber => $cardnumber } ); > my ($issuingimpossible,$needsconfirmation) = CanBookBeIssued( $patron, $item ); > my $issue = AddIssue($patron->unblessed, $item, undef, 0, $issuedate); >- return dt_from_string( $issue->due_date() ); >+ return dt_from_string( $issue->date_due ); > } > > sub try_return { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18797
:
73065
|
73137
|
73294