Bugzilla – Attachment 73069 Details for
Bug 19454
Add the ability to filter on patron category for borrowers-force-messaging-defaults.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19454: (QA follow-up) Fix selection on categorycode
Bug-19454-QA-follow-up-Fix-selection-on-categoryco.patch (text/plain), 1.20 KB, created by
Katrin Fischer
on 2018-03-18 07:34:09 UTC
(
hide
)
Description:
Bug 19454: (QA follow-up) Fix selection on categorycode
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-03-18 07:34:09 UTC
Size:
1.20 KB
patch
obsolete
>From 930dcb1baf6864ef8ab15ca004d9870ec4ec7664 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 14 Mar 2018 13:22:46 +0100 >Subject: [PATCH] Bug 19454: (QA follow-up) Fix selection on categorycode > >A follow-up on a preceding report introduced a join instead of a >subquery. This made the categorycode ambiguous. > >Test plan: >See former patches. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > misc/maintenance/borrowers-force-messaging-defaults.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/maintenance/borrowers-force-messaging-defaults.pl b/misc/maintenance/borrowers-force-messaging-defaults.pl >index e327834..d88d387 100755 >--- a/misc/maintenance/borrowers-force-messaging-defaults.pl >+++ b/misc/maintenance/borrowers-force-messaging-defaults.pl >@@ -57,7 +57,7 @@ WHERE bo.dateenrolled >= ?|; > if( $no_overwrite ) { > $sql .= " AND mp.borrowernumber IS NULL"; > } >- $sql .= " AND categorycode = ?" if $category; >+ $sql .= " AND bo.categorycode = ?" if $category; > my $sth = $dbh->prepare($sql); > $sth->execute($since, $category || () ); > my $cnt = 0; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19454
:
68176
|
68177
|
68202
|
68203
|
69205
|
69206
|
71654
|
71655
|
72849
|
72850
|
72851
|
72852
|
72853
|
72854
|
73067
|
73068
| 73069