Attachment 73097 Details for Bug 15492 – Bug 15492: (QA followup) Make page refresh work correctly

[patch] Bug 15492: (QA followup) Make page refresh work correctly

Bug-15492-QA-followup-Make-page-refresh-work-corre.patch (text/plain), 2.54 KB, created by Tomás Cohen Arazi (tcohen) on 2018-03-19 19:32:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2018-03-19 19:32:15 UTC

Size: 2.54 KB

patch

obsolete

>From 3c69e3545a7a820efa3d8899129a29078cd2e770 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 19 Mar 2018 16:31:52 -0300
>Subject: [PATCH] Bug 15492: (QA followup) Make page refresh work correctly
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 9 ++++-----
> opac/sci/sci-main.pl                                     | 2 +-
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
>index 6d78a590ce..e042aee850 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
>@@ -168,7 +168,7 @@
>             </div> 
>         </div> 
> 
>-        [% IF ( Koha.Preference('SelfCheckInMainUserBlock' ) ) %]
>+        [% IF ( Koha.Preference('SelfCheckInMainUserBlock') ) %]
>             <div id="SelfCheckInMainUserBlock">[% Koha.Preference('SelfCheckInMainUserBlock' ) %]</div>
>         [% END %]
>     </div> 
>@@ -245,8 +245,8 @@
> 
>         var idleTime = 0;
>         $(document).ready(function () {
>-            //Increment the idle time counter every minute.
>-            var idleInterval = setInterval(timerIncrement, 1000); // 1 second
>+            //Increment the idle time counter every second
>+            var idleInterval = setInterval(timerIncrement, 1000);
> 
>             //Zero the idle timer on mouse movement.
>             $(this).mousemove(function (e) {
>@@ -262,8 +262,7 @@
>                 idleTime = idleTime + 1;
>                 idleTimeout = [% refresh_timeout %];
>                 if (idleTime >= idleTimeout ) {
>-                    if ( $("#sci_finish_button").is(":visible") ) $("#sci_finish_button").click();
>-                    if ( $("#sci_refresh_button").is(":visible") ) $("#sci_refresh_button").click();
>+                    location.href = '/cgi-bin/koha/sci/sci-main.pl';
>                 }
>             }
>         }
>diff --git a/opac/sci/sci-main.pl b/opac/sci/sci-main.pl
>index e5ccc72122..b76179ecf4 100755
>--- a/opac/sci/sci-main.pl
>+++ b/opac/sci/sci-main.pl
>@@ -93,7 +93,7 @@ if ( $op eq 'check_in' ) {
>     $template->param( success => \@success, errors => \@errors, checkins => 1 );
> }
> 
>-# Make sure timeour has a reasonable value
>+# Make sure timeout has a reasonable value
> my $timeout = C4::Context->preference('SelfCheckInTimeout') // 120;
> $template->param( refresh_timeout => $timeout );
> 
>-- 
>2.14.1

Actions: View | Diff | Splinter Review

Attachments on bug 15492: 69165 | 69166 | 69167 | 69168 | 69179 | 69664 | 69665 | 70073 | 70074 | 70075 | 70173 | 70174 | 70175 | 70176 | 70177 | 70178 | 70179 | 72053 | 72054 | 72055 | 72056 | 72057 | 72058 | 72059 | 72060 | 72176 | 72177 | 72178 | 72179 | 72180 | 72181 | 72182 | 72183 | 73097