Bugzilla – Attachment 73101 Details for
Bug 20452
Add HTML classes to search results availability data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20452: Add HTML classes to search results availability data
0001-Bug-20452-Add-HTML-classes-to-search-results-availab.patch (text/plain), 9.97 KB, created by
paxed
on 2018-03-20 10:54:06 UTC
(
hide
)
Description:
Bug 20452: Add HTML classes to search results availability data
Filename:
MIME Type:
Creator:
paxed
Created:
2018-03-20 10:54:06 UTC
Size:
9.97 KB
patch
obsolete
>From 9a50e66d6d24143c8c866fd3e6505f666f2f88e4 Mon Sep 17 00:00:00 2001 >From: Pasi Kallinen <pasi.kallinen@joensuu.fi> >Date: Tue, 20 Mar 2018 12:41:39 +0200 >Subject: [PATCH] Bug 20452: Add HTML classes to search results availability > data > >The data in the Location-column in the search results table is >impossible to style because there are no HTML classes. Sprinkle >those around, so libraries can hide information they don't need. > >Test plan: >1) Apply patch >2) Search for biblios >3) Check that the data in the Location-column looks correct. >4) Optionally, look through the page source that it looks correct. > >Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> >--- > .../prog/en/modules/catalogue/results.tt | 48 +++++++++++----------- > 1 file changed, 24 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 459bc085df..1f83e0b018 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -489,7 +489,7 @@ > </strong> > > [% IF ( SEARCH_RESULT.availablecount ) %] >- <ul> >+ <ul class="availablecount"> > [% FOREACH available_items_loo IN SEARCH_RESULT.available_items_loop %] > > [% IF item_level_itypes && !noItemTypeImages && available_items_loo.imageurl %] >@@ -498,12 +498,12 @@ > [% ELSE %] > <li> > [% END %] >- [% IF ( available_items_loo.branchname ) %][% available_items_loo.branchname %][% END %] >- [% IF ( available_items_loo.location ) %][% available_items_loo.location %][% END %] >- [% IF ( available_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=%22[% available_items_loo.itemcallnumber |uri %]%22">[% available_items_loo.itemcallnumber %]</a>][% END %] >- ([% available_items_loo.count %]) >+ [% IF ( available_items_loo.branchname ) %]<span class="branch">[% available_items_loo.branchname %]</span>[% END %] >+ [% IF ( available_items_loo.location ) %]<span class="location">[% available_items_loo.location %]</span>[% END %] >+ [% IF ( available_items_loo.itemcallnumber ) %]<span class="itemcn">[<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=%22[% available_items_loo.itemcallnumber |uri %]%22">[% available_items_loo.itemcallnumber %]</a>]</span>[% END %] >+ <span class="count">([% available_items_loo.count %])</span> > [% IF item_level_itypes && available_items_loo.description %] >- <br/>[% available_items_loo.description %] >+ <br/><span class="descr">[% available_items_loo.description %]</span> > [% END %] > </li> > [% END %] >@@ -512,7 +512,7 @@ > > [% IF ( SEARCH_RESULT.onloancount ) %] > <span class="status">[% SEARCH_RESULT.onloancount %] on loan:</span> >- <ul> >+ <ul class="onloancount"> > [% FOREACH onloan_items_loo IN SEARCH_RESULT.onloan_items_loop %] > [% IF item_level_itypes && !noItemTypeImages && onloan_items_loo.imageurl %] > <li style="list-style: none; list-style-type: none;"> >@@ -520,12 +520,12 @@ > [% ELSE %] > <li> > [% END %] >- [% IF ( onloan_items_loo.branchname ) %][% onloan_items_loo.branchname %][% END %] >- [% IF ( onloan_items_loo.location ) %][% onloan_items_loo.location %][% END %] >- [% IF ( onloan_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=%22[% onloan_items_loo.itemcallnumber |uri %]%22">[% onloan_items_loo.itemcallnumber %]</a>][% END %] >- ([% onloan_items_loo.count %][% IF ( onloan_items_loo.longoverdue ) %], [% onloan_items_loo.longoverdue %] long overdue[% END %]) date due: [% onloan_items_loo.due_date | $KohaDates %] >+ [% IF ( onloan_items_loo.branchname ) %]<span class="branch">[% onloan_items_loo.branchname %]</span>[% END %] >+ [% IF ( onloan_items_loo.location ) %]<span class="location">[% onloan_items_loo.location %]</span>[% END %] >+ [% IF ( onloan_items_loo.itemcallnumber ) %]<span class="itemcn">[<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=%22[% onloan_items_loo.itemcallnumber |uri %]%22">[% onloan_items_loo.itemcallnumber %]</a>]</span>[% END %] >+ <span class="count">([% onloan_items_loo.count %][% IF ( onloan_items_loo.longoverdue ) %]<span class="longoverdue">, [% onloan_items_loo.longoverdue %] long overdue</span>[% END %])</span> <span class="datedue">date due: [% onloan_items_loo.due_date | $KohaDates %]</span> > [% IF item_level_itypes && onloan_items_loo.description %] >- <br/>[% onloan_items_loo.description %] >+ <br/><span class="descr">[% onloan_items_loo.description %]</span> > [% END %] > </li> > [% END %] >@@ -534,7 +534,7 @@ > > [% IF ( SEARCH_RESULT.othercount ) %] > <span class="unavailable">[% SEARCH_RESULT.othercount %] unavailable:</span> >- <ul> >+ <ul class="othercount"> > [% FOREACH other_items_loo IN SEARCH_RESULT.other_items_loop %] > [% IF item_level_itypes && !noItemTypeImages && other_items_loo.imageurl %] > <li style="list-style: none; list-style-type: none;"> >@@ -542,18 +542,18 @@ > [% ELSE %] > <li> > [% END %] >- [% IF ( other_items_loo.branchname ) %][% other_items_loo.branchname %][% END %] >- [% IF ( other_items_loo.location ) %][% other_items_loo.location %][% END %] >- [% IF ( other_items_loo.itemcallnumber ) %][<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=%22[% other_items_loo.itemcallnumber |uri %]%22">[% other_items_loo.itemcallnumber %]</a>][% END %] >- [% IF ( other_items_loo.withdrawn ) %](Withdrawn)[% END %] >- [% IF ( other_items_loo.itemlost ) %](Lost)[% END %] >- [% IF ( other_items_loo.damaged ) %](Damaged)[% END %] >- [% IF ( other_items_loo.intransit ) %](In transit)[% END %] >- [% IF ( other_items_loo.onhold ) %](On hold)[% END %] >- [% IF ( other_items_loo.notforloan ) %][% other_items_loo.notforloan %][% END %] >- ([% other_items_loo.count %]) >+ [% IF ( other_items_loo.branchname ) %]<span class="branch">[% other_items_loo.branchname %]</span>[% END %] >+ [% IF ( other_items_loo.location ) %]<span class="location">[% other_items_loo.location %]</span>[% END %] >+ [% IF ( other_items_loo.itemcallnumber ) %]<span class="itemcn">[<a href="/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=%22[% other_items_loo.itemcallnumber |uri %]%22">[% other_items_loo.itemcallnumber %]</a>]</span>[% END %] >+ [% IF ( other_items_loo.withdrawn ) %]<span class="withdrawn">(Withdrawn)</span>[% END %] >+ [% IF ( other_items_loo.itemlost ) %]<span class="lost">(Lost)</span>[% END %] >+ [% IF ( other_items_loo.damaged ) %]<span class="damaged">(Damaged)</span>[% END %] >+ [% IF ( other_items_loo.intransit ) %]<span class="intransit">(In transit)</span>[% END %] >+ [% IF ( other_items_loo.onhold ) %]<span class="onhold">(On hold)</span>[% END %] >+ [% IF ( other_items_loo.notforloan ) %]<span class="notforloan">[% other_items_loo.notforloan %]</span>[% END %] >+ <span class="count">([% other_items_loo.count %])</span> > [% IF item_level_itypes && other_items_loo.description %] >- <br/>[% other_items_loo.description %] >+ <br/><span class="descr">[% other_items_loo.description %]</span> > [% END %] > </li> > [% END %] >-- >2.11.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20452
: 73101