Attachment 73156 Details for Bug 20446 – Bug 20446 Revert to using syspref for item creation

[patch] Bug 20446 Revert to using syspref for item creation

Bug-20446-Revert-to-using-syspref-for-item-creatio.patch (text/plain), 1.27 KB, created by Kyle M Hall (khall) on 2018-03-22 11:10:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2018-03-22 11:10:45 UTC

Size: 1.27 KB

patch

obsolete

>From 0fca4e82b639df3625dd63b3cde688f044a77c63 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Mon, 19 Mar 2018 10:45:26 +0000
>Subject: [PATCH] Bug 20446 Revert to using syspref for item creation
>
>Using a per-basket setting is nonsensical when baskets
>are created automatically by quote processing a few lines before
>this attempts to read it. cron job aborts with a runtime error
>leaving basket for quote half-created.
>This reverts to the previous code using the global setting.
>(Basket itself will have been set to the global setting
>by default)
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/EDI.pm | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/Koha/EDI.pm b/Koha/EDI.pm
>index bad68d1995..1a15507171 100644
>--- a/Koha/EDI.pm
>+++ b/Koha/EDI.pm
>@@ -797,9 +797,7 @@ sub quote_item {
>                     );
>                 }
> 
>-                my $basket = Koha::Acquisition::Basket->find( $basketno );
>-
>-                if ( $basket->effective_create_item eq 'ordering' ) {
>+                if ( C4::Context->preference('AcqCreateItem') eq 'ordering' ) {
>                     my $new_item = {
>                         notforloan       => -1,
>                         cn_sort          => q{},
>-- 
>2.14.3 (Apple Git-98)

Actions: View | Diff | Splinter Review

Attachments on bug 20446: 73090 | 73103 | 73104 | 73156 | 73424 | 73736 | 73756