Bugzilla – Attachment 7316 Details for
Bug 7461
cart offering to remove items when closing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing
SIGNED-OFF-Bug-7461---Cart-offering-to-remove-item.patch (text/plain), 2.46 KB, created by
Nicole C. Engard
on 2012-01-24 14:29:29 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2012-01-24 14:29:29 UTC
Size:
2.46 KB
patch
obsolete
>From 08aaf147dfd9180c3e2b91b3e220757cb01b13cc Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 24 Jan 2012 09:10:46 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 7461 - Cart offering to remove items when closing > >The "hide window" button in the cart called a quit() function >which deletes any checked items. My understanding of the "hide >window" button is that it should *only* hide the window, not >perform any other operations. I'm removing the calls to the >quit() function in both the OPAC and staff client and adding >a CSS class, "close," which is already tied via jQuery to >the window.close() function. > >To test in both OPAC and staff client: Add items to the cart. >Try clicking the "hide window" button with items selected and >without. In both cases the window should close without affecting >the contents of the cart. > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/basket/basket.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >index 0896075..4239b4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt >@@ -108,7 +108,7 @@ function placeHold () { > </li> > <li> > <span id="hide" class="yui-button yui-link-button"><span class="first-child"> >- <a class="hide" href="basket.pl" onclick="quit(); return false;">Hide Window</a> >+ <a class="hide close" href="basket.pl">Hide Window</a> > </span></span> > </li> > </ul> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt >index 62be158..a229521 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt >@@ -128,7 +128,7 @@ function tagAdded() { > <li><a class="download" href="opac-basket.pl" onclick="downloadBasket(); return false;">Download</a></li> > <li><a class="print" href="opac-basket.pl" onclick="printBasket(); return false;">Print</a></li> > <li><a class="empty" href="opac-basket.pl" onclick="delBasket(); return false;">Empty and Close</a></li> >- <li><a class="hide" href="opac-basket.pl" onclick="quit(); return false;">Hide Window</a></li> >+ <li><a class="hide close" href="opac-basket.pl">Hide Window</a></li> > </ul> > </div> > [% END %] >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7461
:
7314
| 7316