Bugzilla – Attachment 73161 Details for
Bug 17978
Include 'Next available'/title level holds in holds count when placing holds (opac and staff)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17978 - Circ rules will not limit holds
Bug-17978---Circ-rules-will-not-limit-holds.patch (text/plain), 1.44 KB, created by
Marcel de Rooy
on 2018-03-23 07:43:44 UTC
(
hide
)
Description:
Bug 17978 - Circ rules will not limit holds
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-03-23 07:43:44 UTC
Size:
1.44 KB
patch
obsolete
>From 11661a205cf88c83a0e4719e341692c9f611815d Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 19 Dec 2017 14:20:56 -0500 >Subject: [PATCH] Bug 17978 - Circ rules will not limit holds >Content-Type: text/plain; charset=utf-8 > >The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose. > >Test Plan: >1) Set ReservesControlBranch to "item's home library" >2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds >3) Place 3 record level holds, you can but you should not be able to! >4) Delete the holds >5) Apply this patch >6) Attempt to place 3 record level holds >7) Note that you cannot! > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 73b86b6..c9e954e 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -369,7 +369,7 @@ sub CanItemBeReserved { > > # we retrieve count > >- $querycount .= "AND $branchfield = ?"; >+ $querycount .= "AND ( $branchfield = ? OR $branchfield IS NULL )"; > > # If using item-level itypes, fall back to the record > # level itemtype if the hold has no associated item >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17978
:
69927
|
72547
|
73161
|
83476
|
83477
|
86829
|
86830
|
86831
|
87280
|
87281
|
87282